-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.2.0] Filter unavailable users and remove unavailable shares on polling #35073
Conversation
@individual-it can you check the error in https://drone.owncloud.com/owncloud/core/16933/903 ? it's not related but suspicious nonetheless. |
I guess the problem is that we try to run some JS script from the acceptance tests before FF has loaded and run all jQuery files |
restarted failed build |
build was cancelled, probably because of some drone issue, several job run for more than 2h. restarted |
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35073 +/- ##
====================================================
+ Coverage 64.29% 64.29% +<.01%
- Complexity 20040 20044 +4
====================================================
Files 1285 1285
Lines 76824 76846 +22
Branches 1307 1307
====================================================
+ Hits 49394 49410 +16
- Misses 27049 27055 +6
Partials 381 381
Continue to review full report at Codecov.
|
Backport of #35010
Description
Protect polling from exploding on unavailable users
Motivation and Context
An unhandled exception has been thrown: TypeError: Argument 1 passed to OCA\Files_Sharing\External\MountProvider::getMountsForUser() must implement interface OCP\IUser, null given,
when UserManager knows nothing about a userIdHow Has This Been Tested?
update oc_share_external set user="Iwouldliketobreakthepolling" limit 1;
Expected
Polling goes through all entries with no termination
Actual
Polling terminates with
TypeError: Argument 1 passed to OCA\Files_Sharing\External\MountProvider::getMountsForUser() must implement interface OCP\IUser, null given
Types of changes
Checklist: