Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Filter unavailable users and remove unavailable shares on polling #35106

Closed
wants to merge 0 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 26, 2019

Backport #35010
so that stable10 QA tarball is more up-to-date

Also note, has been backported to release-10.2.0 in PR #35073

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #35106 into stable10 will increase coverage by <.01%.
The diff coverage is 79.31%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35106      +/-   ##
==============================================
+ Coverage       64.46%   64.47%   +<.01%     
- Complexity      20064    20068       +4     
==============================================
  Files            1286     1286              
  Lines           76928    76950      +22     
  Branches         1307     1307              
==============================================
+ Hits            49594    49611      +17     
- Misses          26953    26958       +5     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.68% <79.31%> (ø) 20068 <3> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
...s/federatedfilesharing/lib/AppInfo/Application.php 45.89% <0%> (-0.97%) 19 <0> (ø)
...atedfilesharing/lib/Command/PollIncomingShares.php 98.52% <100%> (+0.41%) 13 <2> (+2) ⬆️
apps/files_sharing/lib/External/Manager.php 77.38% <40%> (-1.28%) 32 <1> (+2)
lib/private/Server.php 86.66% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5a04...c66254f. Read the comment docs.

@phil-davis phil-davis closed this May 24, 2019
@phil-davis phil-davis deleted the stable10-improve-polling branch May 24, 2019 11:05
@phil-davis
Copy link
Contributor Author

change was merged from release-10.2.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant