-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Words for "Unable to create user due to exception" #36020
Comments
@micbar @DeepDiver1975 @sharidas |
Thanks for the catch @phil-davis 👍 I agree with 2) |
@phil-davis closed through #36022 or further adjustments needed ? |
What to do about??
|
PR #35972 added the text
Unable to create user due to exception:
to the front of error messages when creating a user.There is a PR in the
user_management
app Move user creation logic to a separate service in core owncloud-archive/user_management#196 that makes the core changes happen to theuser_management
UI. That has not been merged yet, because theuser_management
app is "in limbo" right now. In the past, "normally", that would have been merged. Then the coremaster
PR would be backported tostable10
and theuser_management
app changes would also be "backported" into corestable10
. Now that we do not havestable10
, IMO the process should be that the changes proposed in Move user creation logic to a separate service in core owncloud-archive/user_management#196 should be applied to coremaster
.If we do (1), then the error messages shown to the user when creating a new user look like:
That has excess text. The
user_management
textError creating user:
could be removed.But the words "due to exception" IMO are not very nice to present to a user (even though they are the admin user). Maybe the words used in
core
can be justUnable to create user:
Then the message that comes in OCS status and to real users on the UI would be:
The text
Unable to create user due to exception
is not getting translated. So if the admin user has set their language to something other than English, the message they get hasUnable to create user due to exception
in English andThe password contains too few lowercase letters. At least one lowercase letter is required
in their own language.The changes are only for when a user is added. When an existing user password is changed then the existing error text is displayed. So it becomes a bit inconsistent. For changes, it could say
Unable to modify user:
maybe.The text was updated successfully, but these errors were encountered: