Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words for "Unable to create user due to exception" #36020

Open
phil-davis opened this issue Aug 13, 2019 · 6 comments
Open

Words for "Unable to create user due to exception" #36020

phil-davis opened this issue Aug 13, 2019 · 6 comments

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Aug 13, 2019

PR #35972 added the text Unable to create user due to exception: to the front of error messages when creating a user.

  1. There is a PR in the user_management app Move user creation logic to a separate service in core owncloud-archive/user_management#196 that makes the core changes happen to the user_management UI. That has not been merged yet, because the user_management app is "in limbo" right now. In the past, "normally", that would have been merged. Then the core master PR would be backported to stable10 and the user_management app changes would also be "backported" into core stable10. Now that we do not have stable10, IMO the process should be that the changes proposed in Move user creation logic to a separate service in core owncloud-archive/user_management#196 should be applied to core master.

  2. If we do (1), then the error messages shown to the user when creating a new user look like:

Error creating user: Unable to create user due to exception: The password contains too few lowercase letters. At least one lowercase letter is required.

That has excess text. The user_management text Error creating user: could be removed.

But the words "due to exception" IMO are not very nice to present to a user (even though they are the admin user). Maybe the words used in core can be just Unable to create user:
Then the message that comes in OCS status and to real users on the UI would be:

Unable to create user: The password contains too few lowercase letters. At least one lowercase letter is required.
  1. The text Unable to create user due to exception is not getting translated. So if the admin user has set their language to something other than English, the message they get has Unable to create user due to exception in English and The password contains too few lowercase letters. At least one lowercase letter is required in their own language.

  2. The changes are only for when a user is added. When an existing user password is changed then the existing error text is displayed. So it becomes a bit inconsistent. For changes, it could say Unable to modify user: maybe.

@phil-davis
Copy link
Contributor Author

@micbar @DeepDiver1975 @sharidas
What to do? Maybe nothing?

@pmaier1
Copy link
Contributor

pmaier1 commented Aug 13, 2019

Thanks for the catch @phil-davis 👍 I agree with 2)

@PVince81
Copy link
Contributor

@phil-davis closed through #36022 or further adjustments needed ?

@phil-davis
Copy link
Contributor Author

What to do about??

  1. Unable to create user is not translated - that will result in, for example, password policy messages that are partly in English and partly in the selected local language. Maybe this is really a bigger question about translation of exception message text (which sometimes ends up in a log file or other "technical" place, and sometimes is used to generate a message to a human user)

  2. Do we want to have a similar format message for when a user modify cannot be done.

@PVince81
Copy link
Contributor

@sharidas any reason why the texts have changed after the refactoring, like with #36019 ? any chance to align them and make them look like what they were before ?

Any further changes and translations would need to be done separately later.

@sharidas
Copy link
Contributor

sharidas commented Sep 4, 2019

This is no longer valid, as the changes were reverted: #36122. But this issue would be considered for #36145 (deferred as of now )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants