Revert "Move user creation to a separate service"

[sharidas]

This reverts commit 30f0a5e.

Description

No sufficient time to stabilize for 10.3. Hence we need to revert the change.

Related Issue

• Fixes <issue_link>

Motivation and Context

There are inconsistencies with the messages written in the console. And hence there is not sufficient time to stabilize it before 10.3. Hence reverting the change.

How Has This Been Tested?

• After reverting the change:
• Create user command line:

sujith@sujith-ownCloud  ~/test/owncloud3   revert-pr-35972 ●  ./occ user:add --display-name "Test User1" --email "********" --group "group1" --group "group2" user1
Cannot load Xdebug - it was already loaded
Enter password: 
Confirm password: 
The user "user1" was created successfully
Display name set to "Test User1"
Email address set to "********"
Created group "group1"
User "user1" added to group "group1"
Created group "group2"
User "user1" added to group "group2"
 sujith@sujith-ownCloud  ~/test/owncloud3   revert-pr-35972 ● 

• Create user using provision api:

sujith@sujith-ownCloud  ~/test/owncloud3   revert-pr-35972 ●  curl -X POST http://admin:admin@localhost/testing3/ocs/v1.php/cloud/users -d userid="test2" -d email='*****' -d groups\[\]="group1" -d groups\[\]="group2" -d password="1"
<?xml version="1.0"?>
<ocs>
 <meta>
  <status>ok</status>
  <statuscode>100</statuscode>
  <message/>
 </meta>
 <data/>
</ocs>
 sujith@sujith-ownCloud  ~/test/owncloud3   revert-pr-35972 ● 

• Verify that users are available:

sujith@sujith-ownCloud  ~/test/owncloud3   revert-pr-35972 ●  ./occ user:list                                                                                                   
Cannot load Xdebug - it was already loaded
  - admin: admin
  - test2: test2
  - user1: Test User1
 sujith@sujith-ownCloud  ~/test/owncloud3   revert-pr-35972 ●  

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[phil-davis]

Note: this also effectively reverts PR #36022 which adjusted some of the message texts. That is correct.

[codecov]

Codecov Report

Merging #36122 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #36122   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386

Flag	Coverage Δ
#javascript	54% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f1d87...8fdea7f. Read the comment docs.

[codecov]

Codecov Report

Merging #36122 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #36122   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386

Flag	Coverage Δ
#javascript	54% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f1d87...8fdea7f. Read the comment docs.

[PVince81]

👍