Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config switch to disable tech preview APIs #36118

Closed
PVince81 opened this issue Aug 29, 2019 · 4 comments · Fixed by #36124
Closed

Config switch to disable tech preview APIs #36118

PVince81 opened this issue Aug 29, 2019 · 4 comments · Fixed by #36124
Assignees
@VicDeo
Labels
p1-urgent Critical issue, need to consider hotfix with just that issue Type:Bug
Milestone
development

Comments

@PVince81
Copy link
Contributor

The following beta APIs must be disabled by default:

  • Webdav Trashbin API
  • New Public Webdav endpoint

These APIs are not ready to use in production so they should not be exposed.

For Phoenix development, the switch should be enabled, so we need to update the README.
@PVince81 PVince81 added this to the development milestone Aug 29, 2019
@PVince81
Copy link
Contributor Author

Might need to also adjust acceptance tests to enable said switch in their setup.

@phil-davis
Copy link
Contributor

And add some acceptance tests that confirm the APIs do not respond when the switches are off.

@PVince81 PVince81 added Type:Bug p1-urgent Critical issue, need to consider hotfix with just that issue labels Aug 30, 2019
@PVince81
Copy link
Contributor Author

I consider this a release blocker for 10.3 as we don't want to expose those beta APIs

@PVince81
Copy link
Contributor Author

as discussed with @hodyroff, it should be called "tech preview", not "beta".

@VicDeo VicDeo mentioned this issue Aug 30, 2019
Merged
18 tasks
@phil-davis phil-davis mentioned this issue Sep 3, 2019
Closed
14 tasks
@PVince81 PVince81 changed the title Config switch to disable beta APIs Config switch to disable tech preview APIs Sep 5, 2019
@PVince81 PVince81 mentioned this issue Sep 5, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VicDeo VicDeo

Labels
p1-urgent Critical issue, need to consider hotfix with just that issue Type:Bug
Projects
None yet
Milestone
development
Development

Successfully merging a pull request may close this issue.

Disable trashbin and public webdav API by default owncloud/core
3 participants
@PVince81 @VicDeo @phil-davis