Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/36118 tests #36141

Closed
wants to merge 5 commits into from
Closed

[WIP] Feature/36118 tests #36141

wants to merge 5 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 3, 2019

Description

Get tests running for "Disable trashbin and public webdav API by default"

  • cherry-pick from regenerate .drone.yml #36140 to get a fresh up-to-date .drone.yml
  • modify pipeline.libsonnet so it enables tech_preview for litmus tests
  • add test steps to acceptance test features that need tech_preview enabled
  • add acceptance test scenarios for when tech_preview is disabled

Related Issue

#36118

Motivation and Context

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Sep 3, 2019
@phil-davis phil-davis changed the title Feature/36118 tests [WIP] Feature/36118 tests Sep 3, 2019
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #36141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36141   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdcbf22...c330fad. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #36141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36141   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba978d8...4c080db. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Code has been cherry-picked and squashed into PR #36124

@phil-davis
Copy link
Contributor Author

I will do "add acceptance test scenarios for when tech_preview is disabled" in another PR

@phil-davis phil-davis closed this Sep 3, 2019
@phil-davis phil-davis deleted the feature/36118-tests branch September 3, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants