-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot share top-level of read-only storage #36803
Comments
A similar case is when Anne has received a share from someone and has "can share" permission and the received share is read-only. When Anne tries to reshare the received share to Bob, the UI happily understands that the received share is read-only, and so it makes the reshare read-only also. Anne does not even see the not-allowed permission checkboxes for "can edit"... I guess that in the read-only |
AFAIK It has been always the behaviour implemented and we decided that 'was fine' in this way (cc @pmaier1 just maybe for more feedback) |
This is a bit different new scenario. Local storage can now be explicitly set to read-only (regardless of the underlying storage file/folder permissions). So now "ordinary installs" can set local-storage to read-only. When they do that, there is this webUI problem (which maybe is something we "live with" or we fix) |
@pmaier1 IMO we can leave that now |
Moved this to QA/CI to make sure there is some acceptance test that demonstrates the behavior.
Tag the scenarios with this issue number. Then someone can decide if the behavior needs to be changed. |
Can you share the top level if it's not set to read-only? To me it makes sense that only children can be shared as "sharing" the top level works via the actual external storage mount. Still, there should not be inconsistency with read-only. |
I guess that the use-case is where the is some local storage called That should work appropriately whether the local storage has been mounted read-only or read-write. |
Removed QA assignment. There are acceptance tests for this now. Fixing it can be scheduled. Note: owncloud/files_primary_s3#351 - there might be some different behavior happening with ceph/scality object storage. QA will investigate in that files_primary_s3 issue |
This is working OK in files_primary_s3. See owncloud/files_primary_s3#367 for the test scenario. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed. |
Steps to reproduce
local-folder
local-folder
with "Bob"Expected behaviour
The share should be created with just the allowed "read" permissions
Actual behaviour
Notification is displayed:
and the share is not created.
There is no way to get to the sharing permissions checkboxes and turn off "edit".
(note: it works fine when sharing a sub-folder or file inside
local-folder
. In that case, it "knows" to make the share read-only)Server configuration
Current core master
The "Set read-only" option for storage was added by PR #36397 and issue #29873
The text was updated successfully, but these errors were encountered: