Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Skip local-storage read-only test UI test on ceph and scality object storage #37365

Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 9, 2020

Description

In core, when local storage is set read_only there is a known problem when trying to share the top-level of the storage - issue #36803 A core test scenario demonstrating that was added in PR #37262

The test scenario behaves differently with files_primary_s3 object storage (e.g. ceph or scality)
https://drone.owncloud.com/owncloud/files_primary_s3/1680/15/19

  @issue-36803
  Scenario: applicable user is not able to share top-level of read-only storage                                                               # /var/www/owncloud/testrunner/tests/acceptance/features/webUIAdminSettings/adminStorageSettings.feature:168
    Given these users have been created with default attributes and without skeleton files:                                                   # FeatureContext::theseUsersHaveBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
      | username |
      | user0    |
      | user1    |
    And the administrator has enabled the external storage                                                                                    # OccContext::enableExternalStorageUsingOccAsAdmin()
    And the administrator has browsed to the admin storage settings page                                                                      # WebUIAdminStorageSettingsContext::theAdministratorHasBrowsedToTheAdminStorageSettingsPage()
    And the administrator has created the local storage mount "local_storage1" from the admin storage settings page                           # WebUIAdminStorageSettingsContext::theAdministratorHasCreatedTheLocalStorageMountUsingTheWebui()
    And the administrator has added user "user0" as the applicable user for the last local storage mount from the admin storage settings page # WebUIAdminStorageSettingsContext::theAdministratorAddsUserAsTheApplicableUserForTheLastLocalStorageMountUsingTheUsingTheWebui()
    And the administrator has enabled read-only for the last created local storage mount using the webUI                                      # WebUIAdminStorageSettingsContext::theAdministratorEnablesReadonlyForTheLastCreatedLocalStorageMountUsingTheWebui()
    And the administrator has enabled sharing for the last created local storage mount using the webUI                                        # WebUIAdminStorageSettingsContext::theAdministratorHasEnabledSharingForTheLastCreatedLocalStorageMountUsingTheWebui()
    And the user has re-logged in as "user0" using the webUI                                                                                  # WebUILoginContext::theUserHasReloggedInUsingTheWebUI()
    When the user shares folder "local_storage1" with user "User One" using the webUI                                                         # WebUISharingContext::theUserSharesFileFolderWithUserUsingTheWebUI()
    Then notifications should be displayed on the webUI with the text                                                                         # WebUIGeneralContext::notificationsShouldBeDisplayedOnTheWebUIWithTheText()
      | Cannot set the requested share permissions for local_storage1 |
      expected at least 1 notifications but only found 0
      Failed asserting that 0 is equal to 1 or is greater than 1.
    And as "user1" folder "local_storage1" should not exist                                                                                   # FeatureContext::asFileOrFolderShouldNotExist()
SCENARIO RESULT: (fail)

--- Failed scenarios:

    /var/www/owncloud/testrunner/tests/acceptance/features/webUIAdminSettings/adminStorageSettings.feature:168

1 scenario (1 failed)
11 steps (9 passed, 1 failed, 1 skipped)
0m59.96s (24.35Mb)
webUI test rerun failed with exit status: 1

There is no error in the webUI. So perhaps the sharing works in this case. But I suspect that there is more to it - perhaps it shares with full permissions rather than read_only??? I raised owncloud/files_primary_s3#351 to investigate that in files_primary_s3

Skip the scenario when testing with ceph or scality. We can write specific test scenarios in files_primary_s3 when we understand how the problem is different there.

Related Issue

#36803
owncloud/files_primary_s3#351

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #37365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37365   +/-   ##
=========================================
  Coverage     64.56%   64.56%           
  Complexity    19218    19218           
=========================================
  Files          1268     1268           
  Lines         75104    75104           
  Branches       1331     1331           
=========================================
  Hits          48493    48493           
  Misses        26219    26219           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.72% <ø> (ø) 19218.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bb3236...c4f242b. Read the comment docs.

@individual-it individual-it merged commit 4c799a7 into master May 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the skip-local-storage-read-only-test-on-ceph-scality branch May 11, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants