Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files sharing notification email is in english, even though the preferred language is set to german. #37039

Closed
weberdigital opened this issue Feb 27, 2020 · 1 comment · Fixed by #37056
Assignees

Comments

@weberdigital
Copy link

Steps to reproduce

  1. Click on the sharing button on a file or a directory
  2. Share with a user or a group
  3. Send mail by pressing on "Notify by email"

Expected behaviour

The mail shoud be in the preferred language of the recipient.

Actual behaviour

The mail is in english, even though the preferred language is set to german (de_DE) in the config.php with the default_language entry.

'default_language' => 'de_DE'

This happens, because when a user gets created, it still has no value for the langkey in the oc_preferences table. However, the MailNotifications.php (line 168) looks for this. If it doesn't find anything, it will fallback to the english language.

Here is the query to check it:

SELECT appid, configkey, configvalue, userid FROM oc_preferences WHERE configkey = 'lang';

So when creating a user it should either set the value in the oc_preferences table or fallback to the default_language set in the config.php.

Server configuration

Operating system: CentOS 6.10

Web server: Apache

Database: MYSQL

PHP version: 7.2

ownCloud version: 10.3.2

Updated from an older ownCloud or fresh install: from older ownCloud

Where did you install ownCloud from: https://download.owncloud.org/community/owncloud-10.3.2.tar.bz2

Signing status (ownCloud 9.0 and above):
No errors have been found.

The content of config/config.php:

{
    "system": {
        "allow_user_to_change_display_name": false,
        "instanceid": "51dbc8445406e",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "\/var\/www\/vhosts\/redacted\/private\/data\/",
        "dbtype": "mysql",
        "version": "10.3.2.2",
        "dbname": "default_owncloud",
        "dbhost": "localhost",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "default_language": "de_DE",
        "installed": true,
        "forcessl": true,
        "knowledgebaseenabled": false,
        "maintenance": false,
        "trashbin_retention_obligation": "60, auto",
        "remember_login_cookie_lifetime": 2592000,
        "loglevel": 3,
        "trusted_domains": [
            "redacted",
            "redacted"
        ],
        "secret": "***REMOVED SENSITIVE VALUE***",
        "share_folder": "\/Shared",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "sendmail",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "tempdirectory": "\/var\/www\/vhosts\/redacted\/vhost-temp\/",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "localhost",
            "port": 6379
        }
    }
}

List of activated apps:

Enabled:
  - activity: 2.5.2
  - calendar: 1.6.3
  - comments: 0.3.0
  - configreport: 0.2.0
  - customgroups: 0.5.0
  - dav: 0.5.0
  - external: 1.4.0
  - federatedfilesharing: 0.5.0
  - federation: 0.1.0
  - files: 1.5.2
  - files_antivirus: 0.15.1
  - files_external: 0.7.1
  - files_mediaviewer: 1.0.1
  - files_pdfviewer: 0.11.1
  - files_sharing: 0.12.0
  - files_texteditor: 2.3.0
  - files_trashbin: 0.9.1
  - files_versions: 1.3.0
  - firstrunwizard: 1.2.0
  - gallery: 16.1.1
  - impersonate: 0.5.0
  - market: 0.5.0
  - notifications: 0.5.0
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - templateeditor: 0.4.0
  - updatenotification: 0.2.1
  - wes: 1.0.0
Disabled:
  - encryption
  - user_external

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Chrome

Operating system: Windows 10

@VicDeo
Copy link
Member

VicDeo commented Mar 2, 2020

#7417

regression? #34255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants