Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested chown-command in lib/util.php is not platform-independent #3819

Closed
msrex opened this issue Jun 23, 2013 · 4 comments
Closed

Suggested chown-command in lib/util.php is not platform-independent #3819

msrex opened this issue Jun 23, 2013 · 4 comments

Comments

@msrex
Copy link

msrex commented Jun 23, 2013

If the data directory is not readable, the user gets a suggestion to change the permissions. That suggestion is not platform-independent (not even across different Linuxes, let alone Windows). We should either state for which OS this command works, or remove the part with the hint to avoid confusion.

To reproduce:
grep for 'chown' in lib/util.php
@DeepDiver1975
Copy link
Member

https://github.com/owncloud/core/blob/master/lib/util.php#L217

I'd vote for removing this hint

@jancborchardt

@jancborchardt
Copy link
Member

Just removing the hint makes the error message even less helpful. How about we link to the manual page: http://doc.owncloud.org/server/5.0/admin_manual/installation/installation_source.html#set-the-directory-permissions – is that ok?

@DeepDiver1975
Copy link
Member

How about we link to the manual page:

👍 from my point of view

jancborchardt added a commit that referenced this issue Jun 24, 2013
@jancborchardt
link to docs in error messages, fix #3819
3119b36
@jancborchardt jancborchardt mentioned this issue Jun 24, 2013
Closed
@jancborchardt
Copy link
Member

See #3827

schiessle pushed a commit that referenced this issue Jul 8, 2013
Merge #3827
54a1239 
Squashed commit of the following:

commit eed4b49
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Mon Jul 8 10:03:23 2013 +0200

    initialize OC_Defaults only once

commit bf6f07c
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Mon Jul 8 10:02:48 2013 +0200

    link to doc in error messages

commit ea61ee6
Merge: e41af3d 3c1308f
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Thu Jul 4 11:10:56 2013 +0200

    Merge branch 'master' into better-messages

commit e41af3d
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Thu Jul 4 11:10:41 2013 +0200

    move to non-static defaults.php

commit 9e4258b
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Tue Jul 2 10:32:13 2013 +0200

    no sprintf here, lets t() handle it

commit fe1df34
Merge: d8f6859 cb5811b
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Mon Jul 1 11:13:38 2013 +0200

    Merge branch 'master' into better-messages

commit d8f6859
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Mon Jul 1 11:10:57 2013 +0200

    use document base url from defaults.php

commit 6c54037
Merge: bea6b1c 7b0e3e6
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Mon Jul 1 11:00:15 2013 +0200

    Merge branch 'master' into better-messages

commit bea6b1c
Author: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date:   Mon Jun 24 16:21:12 2013 +0200

    link to docs in WebDAV message, ref #3791

commit 3119b36
Author: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date:   Mon Jun 24 16:10:21 2013 +0200

    link to docs in error messages, fix #3819

Conflicts:

	lib/config.php
@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jancborchardt @DeepDiver1975 @msrex