Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] doctrine/dbal is only 2.12.2-DEV #38990

Closed
jnweiger opened this issue Jul 14, 2021 · 2 comments
Closed

[QA] doctrine/dbal is only 2.12.2-DEV #38990

jnweiger opened this issue Jul 14, 2021 · 2 comments

Comments

@jnweiger
Copy link
Contributor

seen in oc 10.8.0-beta2

PR #38647 claims to update octrine/dbal to 2.13.1

But lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Version.php says

class Version
{
    /**
     * Current Doctrine Version.
     */
    public const VERSION = '2.12.2-DEV';

Is this the expected version?

@jnweiger jnweiger changed the title [QA] doctrine/dbal is only 1.12.2-DEV [QA] doctrine/dbal is only 2.12.2-DEV Jul 14, 2021
@phil-davis
Copy link
Contributor

The version is incorrect in the release. I raised issue doctrine/dbal#4711
And made PR doctrine/dbal#4712

IMO this constant does not effect anything "real".

@AlexAndBear
Copy link

AlexAndBear commented Jul 15, 2021

Does not effect anything, hopefully they will fix it in minor patch (but they say won't fix), your level of finding those things is outstanding 👍

Closing due to no (bad) effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants