Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VERSION constant in 2.13 series #4712

Closed
wants to merge 2 commits into from

Conversation

phil-davis
Copy link
Contributor

Q A
Type bug
BC Break no
Fixed issues #4711

Summary

Update the VERSION to be current.

@phil-davis
Copy link
Contributor Author

Static Analysis fails because of:
"RedundantCast - lib/Doctrine/DBAL/Version.php:31:48 - The call to strtolower is unnecessary (see https://psalm.dev/262)"

When the constant VERSION has only numbers and dots, then strtolower() is unnecessary. But as soon as someone adds -DEV on the end, strtolower() will be necessary!

I guess that the code has to be adjusted every time -DEV is added/removed from the string. That's a maintenance headache!

For now, I will also push a commit to move VERSION up to 2.13.3-DEV.

@phil-davis
Copy link
Contributor Author

Closing - see comments in issue. Can easily be re-opened if needed some time.

@phil-davis phil-davis closed this Jul 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant