Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to reusing etags in the scanner #12011

Merged
merged 1 commit into from
Jan 9, 2015
Merged

Conversation

icewind1991
Copy link
Contributor

Prevents etags being re-generated when the scanner is called

cc @DeepDiver1975 @PVince81

@icewind1991
Copy link
Contributor Author

fixes #11995

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@PVince81
Copy link
Contributor

Did you check where this was called ? Is the default valid ?

Also: how to force it to not reuse etags ? Maybe introduce a new "FORCE" constant ? (passing 0 is not so intuitive)

@PVince81 PVince81 mentioned this pull request Nov 28, 2014
22 tasks
@DeepDiver1975
Copy link
Member

Did you check where this was called ? Is the default valid ?

Also: how to force it to not reuse etags ? Maybe introduce a new "FORCE" constant ? (passing 0 is not so intuitive)

From my POV we shall always reuse the existing etag - we might even want to drop some code with respect to this. Nevertheless this might help in some edge cases 👍

@DeepDiver1975 DeepDiver1975 added this to the 8.0-current milestone Dec 22, 2014
@schiessle
Copy link
Contributor

Code looks good... 👍 if Jenkins passes.

@ghost
Copy link

ghost commented Jan 7, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/5978/
👍 Test PASSed. 👍

MorrisJobke added a commit that referenced this pull request Jan 9, 2015
Default to reusing etags in the scanner
@MorrisJobke MorrisJobke merged commit 800738f into master Jan 9, 2015
@MorrisJobke MorrisJobke deleted the reuse-etag-default branch January 9, 2015 13:38
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants