Show user backend in user management #12806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like:
|
23 tasks
|
👍 |
| <p><label> | ||
| <input type="checkbox" name="UserBackend" value="UserBackend" id="CheckboxUserBackend"> | ||
| <?php p($l->t('Show user backend')) ?> | ||
| </label></p> |
There was a problem hiding this comment.
The intendation change is unnecessary?
|
Tested and works as expected |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 16 lines...]Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git4296755707574748955.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12806/merge^{commit} # timeout=10 > git branch -a --contains b9c6d655e426a437df51e164bf09b0fd965166cf # timeout=10 > git rev-parse remotes/origin/pr/12806/merge^{commit} # timeout=10Checking out Revision b9c6d655e426a437df51e164bf09b0fd965166cf (origin/pr/12806/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f b9c6d655e426a437df51e164bf09b0fd965166cfFirst time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 5 minutes💣 Test FAILed. 💣 |
|
2 failign tests are related! : -1 : (invalidated by @MorrisJobke - I fixed the unit test) |
MorrisJobke
force-pushed
the
display-backend-in-usermgnt
branch
from
24895e3 to
6e4337a
Compare
|
@nickvergessen I fixed the unit tests and improved the markup of the settings area too ;) |
* add switch to settings to show user backend * user classes for headers and rows to unify the show/hide statement * add user backend to response of user create request * proper markup in settings area
MorrisJobke
force-pushed
the
display-backend-in-usermgnt
branch
from
6e4337a to
04aaa72
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Code looks good 👍 |
PVince81
pushed a commit
that referenced
this pull request
Dec 12, 2014
Show user backend in user management
|
The inspection completed: 1 new issues, 2 updated code elements |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12604 and #12620
essential commit: 24895e3
cc @PVince81 @LukasReschke @blizzz