Add max parallels to getcapabiltilies #13628
Conversation
If SQLite, limit parallel upload to 1
|
Refer to this link for build results (access rights to CI server needed): |
|
The inspection completed: 10 new issues |
| 'files' => array( | ||
| 'bigfilechunking' => true, | ||
| ), | ||
| 'files' => $caps |
There was a problem hiding this comment.
Add a , at EoL to not have to edit it for future adjustments?
There was a problem hiding this comment.
Also the intendation is off here
|
Should we disallow syncing at all? Parallel upload can result in database locks but multiple clients from multiple users can trigger the same result. For testing and development purpose I want to keep sqlite. Same for low traffic usage - e.g. somebody who uses ownCloud and calendar and files platform for a pure sharing perspective. In such a case sqlite is really sufficient. |
|
I'll only fix this PR once we agree on the approach. |
|
Hmm. In which scenario is it harmful to try to do several WebDAV requests in parallel? |
|
@karlitschek the busy wait handler was removed (if i understand) when switching from mdb2 to doctrine. #13615 @PVince81 ok.. and you'll also add a flag "using_legacy_unperformant_db" or so flag in case we ever want to display a message in the client? (as discussed with @LukasReschke ) |
If the server can't cope with parallel upload, it can advertise it in the capabilities secion Issue #2743 Need owncloud/core#13628
|
Another "SQLite does it all wrong"-issue that breaks our mobile clients: #13705 |
|
I don´t understand this at all. It is possible to process several requests at the same time by using sqlite. We only need the proper locking working. This is best practices for web application for a long time and also worked in ownCloud like that. I don´t know what is currently broken in our code so that this is not working. |
|
Can you guys confirm whether there was data loss involved in this situation ? |
|
A clarification about my previous comment. With the comment "stupid" I was referring to the approach that we work around a possible server bug that can lead to data lose by telling the client to not do parallel requests. If such a bug exists in the core that parallel requests can create data lose that we have to fix this bug and not tell the clients to not do parallel requests. |
|
My pov on the current sqlite situation is described in here #13705 (comment) |
|
Obsoleted by #13752 |
|
I guess you mean obsoleted by #13615 ? |
|
I agree with @karlitschek, it does not make sense to limit the maximum numbers of parallel requests to the server for whatever reason or in whatever situation. While we can prevent the client from doing parallel requests we can not prevent users to use a script (for example) to get into the same situation. So that needs to be fixed, even if sqlite is used. That is not easy to fix as @DeepDiver1975 points out. So we were looking for a solution for the upcoming releases (server 8 and client 1.8) and thus the idea of the capabilities sounds like a compromise for now. |
If the server can't cope with parallel upload, it can advertise it in the capabilities secion Issue #2743 Need owncloud/core#13628
If SQLite, limit parallel upload to 1
Still to be discussed @guruz (in case you change your mind)