Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop OC_Preferences #13869

Merged
merged 1 commit into from
Feb 9, 2015
Merged

drop OC_Preferences #13869

merged 1 commit into from
Feb 9, 2015

Conversation

MorrisJobke
Copy link
Contributor

cc @LukasReschke @DeepDiver1975

I provided PRs for all apps that live in the owncloud org. Two are still open: see #12260

@MorrisJobke MorrisJobke mentioned this pull request Feb 3, 2015
Closed
5 tasks
@MorrisJobke
Copy link
Contributor Author

cc @Raydiation @PVince81

@MorrisJobke MorrisJobke added this to the 8.1-next milestone Feb 3, 2015
@LukasReschke
Copy link
Member

Cool! 👍

@MorrisJobke
Copy link
Contributor Author

@karlitschek
Copy link
Contributor

ok with me as long as the public api doesn´t change.

@scrutinizer-notifier
Copy link

The inspection completed: 4 new issues

@MorrisJobke
Copy link
Contributor Author

@karlitschek I will never break the \OCP\ namespace. We have methods in place there and this just cleans up behind the scenes.

@ghost
Copy link

ghost commented Feb 4, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/8661/
Test PASSed.

@MorrisJobke MorrisJobke mentioned this pull request Feb 4, 2015
Merged
@BernhardPosselt
Copy link
Contributor

👍

@PVince81
Copy link
Contributor

PVince81 commented Feb 9, 2015

👍 goodbye legacy code

PVince81 pushed a commit that referenced this pull request Feb 9, 2015
Merge pull request #13869 from owncloud/drop-oc-preferences
b7b8c0c 
drop OC_Preferences
@PVince81 PVince81 merged commit b7b8c0c into master Feb 9, 2015
@PVince81 PVince81 deleted the drop-oc-preferences branch February 9, 2015 16:48
@MorrisJobke MorrisJobke mentioned this pull request Feb 9, 2015
Closed
2 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
6 participants
@MorrisJobke @LukasReschke @karlitschek @scrutinizer-notifier @BernhardPosselt @PVince81