Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable8] Use transactions when renaming directory contents #14752

Closed
wants to merge 1 commit into from

Conversation

MorrisJobke
Copy link
Contributor

@MorrisJobke MorrisJobke added this to the 8.0.3-next-maintenance milestone Mar 9, 2015
@MorrisJobke MorrisJobke changed the title Use transactions when renaming directory contents [stable8] Use transactions when renaming directory contents Mar 9, 2015
@ghost
Copy link

ghost commented Mar 9, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10261/
Test PASSed.

@PVince81
Copy link
Contributor

PVince81 commented Mar 9, 2015

Bumped into this weird issue: #14757

Now thinking of it, it could somehow be due to the transaction.

@christianrj
Copy link

Some of the bugs I reported related to rename problems:
#10711
#11847
#12659
#12661

@PVince81
Maybe some of them has something to do with #14757

@DeepDiver1975
Copy link
Member

Bumped into this weird issue: #14757

Now thinking of it, it could somehow be due to the transaction.

so - we better holds this back for now 👎

@MorrisJobke MorrisJobke deleted the backport-13948 branch March 10, 2015 08:51
@MorrisJobke MorrisJobke removed this from the 8.0.3-next-maintenance milestone Mar 10, 2015
@PVince81
Copy link
Contributor

Thing is, @jnfrmarks managed to recreate the same issue (mysql lock) on 8.0.2 with smashbox, so I'm not 100% sure whether what I observed was really due to this change or my general "unluck" of being able to trigger random race conditions.

@MorrisJobke
Copy link
Contributor Author

@PVince81 We can redo this easiely, but if it really cause an problem, then we better analyse this before a backport and not once it hit users ;)

@PVince81
Copy link
Contributor

So far it seems that the issues we were seeing were not related to this addition, so we might maybe want to reopen/resend this, at least as a quickfix to reduces the probability of data loss here #13391

@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants