basic WebDAV test in place now

[DeepDiver1975]

Very first attempt to fulfill the requirements defined in #1354.

/**
 * we test if webDAV is working properly
 *
 * The basic assumption is that if the server returns 401/Not Authenticated for an unauthenticated PROPFIND
 * the web server it self is setup properly.
 *
 * Why not an authenticated PROFIND and other verbs?
 *  - We don't have the password available
 *  - We have no idea about other auth methods implemented (e.g. OAuth with Bearer header)
 *
 */

@danimo @bartv2 @karlitschek @icewind1991 @tanghus THX

[icewind1991]

Seems reasonable

👍

[bartv2]

Can we do this in lib/setup? that would be a better place for this check.

[DeepDiver1975]

sorry for the missing info - as described here: #1354 (comment)

the webdav interface is only functional after installation - that's why I did choose this solution.

[bartv2]

isn't the install finished at https://github.com/owncloud/core/blob/master/core/setup.php#L46? we can do the check there

[DeepDiver1975]

but if you reload it will no longer popup

[bartv2]

@DeepDiver1975 what about this?

[DeepDiver1975]

nice solution with the routing - I need to get into this ;-)

but still nothing prevents the user from navigating to the index.php or root url and the check is gone forever

[bartv2]

true, but they say the message, and chose to continue. But we could add a check to the admin screen. Maybe they don't need/want the webdav access

[DeepDiver1975]

seems legit - I'll add the warning to the admin section

[DeepDiver1975]

@bartv2 warning in admin section in place and rebased - wana check it out? THX

[bartv2]

I just noticed the hardcoded doc url, we need to centralize that and make the version dependend on the version in OC_Util. But I think a new PR for that is better.

+1 for this version

[danimo]

Yes, the doc situation needs to be sorted out. @karlitschek was working on integrating the docs for 5.0. Mabye he has a plan. Anyway, the rest looks good, can't test it right now though. Has anyone else except @DeepDiver1975? Otherwise I'd reserve some time later. Which servers were tested? Only IIS? Does Apache have this problem at all?

[karlitschek]

That's tricky. The shipped docu is in an iframe so we can't deeplink to it properly. But we could link to the online documentation of course.

[DeepDiver1975]

@danimo curl test included

[karlitschek]

👍