Add wrapper for Guzzle #15195
Merged
Add wrapper for Guzzle #15195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to review now: |
|
Refer to this link for build results (access rights to CI server needed): |
|
Looks good 👍 |
|
I tested to install an app and did a s2s sharing. There were no errors in the log. |
|
Code also look good 👍 |
|
3rdparty update: 69f14f9 |
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| namespace OCA\Files_Sharing\Controllers; | |||
|
|
|||
| use Hoa\Core\Data\Data; | |||
There was a problem hiding this comment.
Probably pressed enter when typing autocomplete for DataResponse 🙈
… fixing …
| $this->client->setDefaultOption('verify', \OC::$SERVERROOT . '/config/ca-bundle.crt'); | ||
| } | ||
|
|
||
| $this->client->setDefaultOption('headers/User-Agent', 'ownCloud Server Crawler'); |
There was a problem hiding this comment.
what about firewalls rejecting anything which is not a browser? @danimo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other PR because Jenkins didn't like my old one 😢
This adds a wrapper around Guzzle to allow developers to perform HTTP requests using a somewhat saner API. Without this SSL and proxy support is basically broken in ownCloud as stated in #14913 (comment)
Todo
Requires owncloud-archive/3rdparty#167
Fixes #9054, #14963, #14840 and a lot of other issues
Ref #14913