Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The bitmap preview class now takes maxX and maxY into consideration #15349

Merged
merged 1 commit into from
Apr 2, 2015
Merged

The bitmap preview class now takes maxX and maxY into consideration #15349

merged 1 commit into from
Apr 2, 2015

Conversation

oparoz
Copy link
Contributor

@oparoz oparoz commented Mar 31, 2015

Duplicate of #13635

This is a fix for #13607
and is part of the global programme to fix preview caching: #13609

  • Original TIFF: 140MB. Waiting an insane amount of time every time you need a preview because a conversion is asked every time
  • With Introducing the maximum size preview #13674: Preview only resizes a 48MB file. Waiting about a minute for each preview
  • Combined with this: Preview only resizes a 6.7MB file. Waiting about 3 SECONDS.

@karlitschek
Copy link
Contributor

@georgehrke

@oparoz oparoz closed this Apr 1, 2015
@oparoz oparoz deleted the limit-bitmap-previews-2 branch April 1, 2015 00:17
@oparoz oparoz mentioned this pull request Apr 1, 2015
Closed
@oparoz oparoz restored the limit-bitmap-previews-2 branch April 1, 2015 12:18
@oparoz oparoz reopened this Apr 1, 2015
@oparoz
Copy link
Contributor Author

oparoz commented Apr 1, 2015

@icewind1991 @georgehrke @MorrisJobke
This is a duplicate of #13635 to make the bot army happy

@oparoz oparoz added this to the 8.1-current milestone Apr 1, 2015
MorrisJobke
MorrisJobke reviewed Apr 1, 2015
View reviewed changes
lib/private/preview/bitmap.php
*
* This file is licensed under the Affero General Public License version 3 or
* later.
* See the COPYING-README file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this.

@oparoz oparoz self-assigned this Apr 1, 2015
@georgehrke
Copy link
Contributor

please fix what Morris mentioned. Looks good to me otherwise (:+1: once fixed)

@oparoz
The bitmap preview class now takes maxX and maxY into consideration
1525ecd 
This is a fix for #13607 and is part of the global programme: #13609

The image aspect ratio is kept intact.
@scrutinizer-notifier
Copy link

The inspection completed: No issues found

1 similar comment
@scrutinizer-notifier
Copy link

The inspection completed: No issues found

@ghost
Copy link

ghost commented Apr 1, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11155/
🚀 Test PASSed.🚀
chuck

@MorrisJobke
Copy link
Contributor

Still works 👍

MorrisJobke added a commit that referenced this pull request Apr 2, 2015
@MorrisJobke
Merge pull request #15349 from oparoz/limit-bitmap-previews-2
82f91c5 
The bitmap preview class now takes maxX and maxY into consideration
@MorrisJobke MorrisJobke merged commit 82f91c5 into owncloud:master Apr 2, 2015
@oparoz oparoz deleted the limit-bitmap-previews-2 branch April 2, 2015 18:10
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@oparoz oparoz

Labels
3 - To Review feature:previews performance
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
5 participants
@oparoz @karlitschek @georgehrke @scrutinizer-notifier @MorrisJobke