Deprecate functions (OC_Helper + OCP\Util) that only call the urlgenerator anyway #15366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @DeepDiver1975 @LukasReschke @Xenopathic |
|
Makes sense 👍 |
|
Refer to this link for build results (access rights to CI server needed): |
|
The inspection completed: No issues found |
|
👍 |
RobinMcCorkell
pushed a commit
that referenced
this pull request
Apr 1, 2015
Deprecate functions (OC_Helper + OCP\Util) that only call the urlgenerator anyway
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several function in OCP\Util only call functions in OC_Helper which in turn call the urlgenerator.
This PR deprecates the trivial cases so people that touch related code will get warnings to use the urlgenerator directly.
This should make this easier in the long run ;)
Note that this PR is only for the trivial cases. There are several functions (for example linkToPublic) that do not have a counter part in the urlgenerator yet. We should discus what we want to do there. But thats is something for a different PR