-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll the share menu into sight when it's hidden outside the viewport #15817
Conversation
This definitely has too much breakage potential for 8.1 – we are in feature freeze. Setting to 8.2 @oparoz will test in a bit. |
OK :) |
This is actually quite cool! However, I would still use the 300px as height instead of 100. Especially because when you close the share dropdown on the last items, the list moves again, which is strange. |
Having the height at 300px would also simplify things, but let's wait for what the owncloud-designers say in the other thread. That is going to be merged before this anyway. |
We need a more generic solution for dropdowns. |
Refer to this link for build results (access rights to CI server needed): |
The inspection completed: No new issues |
I agree, obsolete if that makes it in. |
Talked with @oparoz and it will be obsolete because of the sharing dialog in the sidebar. |
Nice! :) |
Fix for #15801
I've also taken into consideration the fact that there should be more space at the bottom of the file list and modified the bottom element's height from 60px to 100px.
The bottom of the screen returns to its original height at OC.menuSpeed speed which is very fast.
The problem with a slow change is that the mouse is likely to be placed over the share button and will trigger tipsy events as the bottom shrinks.
@donniezazen - Let me know if this fixes the issue for you
@jancborchardt - Let me know what you think from a UX perspective.
People who might be interested due to their recent tinkering of OC.share: @rullzer @nickvergessen @PVince81