Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll the share menu into sight when it's hidden outside the viewport #15817

Closed
wants to merge 1 commit into from
Closed

Scroll the share menu into sight when it's hidden outside the viewport #15817

wants to merge 1 commit into from

Conversation

oparoz
Copy link
Contributor

@oparoz oparoz commented Apr 22, 2015

Fix for #15801

I've also taken into consideration the fact that there should be more space at the bottom of the file list and modified the bottom element's height from 60px to 100px.

The bottom of the screen returns to its original height at OC.menuSpeed speed which is very fast.
The problem with a slow change is that the mouse is likely to be placed over the share button and will trigger tipsy events as the bottom shrinks.

@donniezazen - Let me know if this fixes the issue for you
@jancborchardt - Let me know what you think from a UX perspective.
People who might be interested due to their recent tinkering of OC.share: @rullzer @nickvergessen @PVince81

@jancborchardt
Copy link
Member

This definitely has too much breakage potential for 8.1 – we are in feature freeze. Setting to 8.2

@oparoz will test in a bit.

@jancborchardt jancborchardt modified the milestones: 8.2-next, 8.1-current Apr 22, 2015
@oparoz
Copy link
Contributor Author

oparoz commented Apr 22, 2015

OK :)
I checked various repositories and didn't find many apps using this, but devs need to be given enough time to test.

@jancborchardt
Copy link
Member

This is actually quite cool! However, I would still use the 300px as height instead of 100. Especially because when you close the share dropdown on the last items, the list moves again, which is strange.

@oparoz
Copy link
Contributor Author

oparoz commented Apr 22, 2015

Having the height at 300px would also simplify things, but let's wait for what the owncloud-designers say in the other thread. That is going to be merged before this anyway.

@PVince81
Copy link
Contributor

We need a more generic solution for dropdowns.
This issue would affect the versions dropdown too.

@ghost
Copy link

ghost commented Apr 23, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11756/
🚀 Test PASSed.🚀
chuck

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@jancborchardt
Copy link
Member

If we do move to a right sidebar with 8.2 (#16414) then this is obsolete. @oparoz did you look at that PR yet – what do you think?

@oparoz
Copy link
Contributor Author

oparoz commented Jun 29, 2015

I agree, obsolete if that makes it in.

@MorrisJobke
Copy link
Contributor

Talked with @oparoz and it will be obsolete because of the sharing dialog in the sidebar.

@jancborchardt
Copy link
Member

Nice! :)

individual-it added a commit that referenced this pull request Mar 17, 2017
This should fix #18830
It uses the fix made by @oparoz for #15817
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants