-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L10n fixes #16
L10n fixes #16
Conversation
Use locale date format with translated month names
Translate modification date when file is created/uploaded
Hi, I'll merge this after 4.5 release. Thx, Tom |
Ok, I'm working in fixing some untranslated strings |
Cool! Many thanks! Tom |
Really all these commits are about untranslated strings, although first commits are not so simple because they are about date localization. I have pushed changes in files_sharing to translate it, although perl l10n.pl read is not picking this one: |
Sorry for being not precise enough: And I need those in a separate pull request - this pull request will be for 5.0. Regarding l10n.pl not catching your string: I have no idea and no time to take care - sorry. Maybe this is just another topic for 5.0 Many thanks again for your support, Tom |
I understand it, I will do a new request with simple changes for 4.5 |
@scambra: I just merged the pull request from Thomas Tanghus regarding js string interpolation. Your contribution is very welcome! Thanks a lot, Tom PS: THX |
Date in tooltip displayed in modification column is not translated, you must setlocale and use strftime to get month translations in PHP.
Also modification column is not translated when a file is created/uploaded, row is created with JS and relative date strings translations in files app was missing, although it's splitting sentences. I added support for sprintf and translation with arguments to JS, and reused relative date strings from lib.
And I added localization for datepicker too, which is used in set expiration date.