Fix for thumbnail creation on File upload OC version 81.beta

[libasys]

If you upload an image that is greater than the config value of preview_max_x/preview_max_y (2048) you run in an issue that the big image also get cropped to 2048 x 2048 cause the first small thumb creation is square 36/36 so the keepAspect is false. with this addition you ge sure the aspect ratio is set to true!

[scrutinizer-notifier]

A new inspection was created.

[BernhardPosselt]

@oparoz

[oparoz]

@libasys - You're right. It's only a problem with the image provider though, so maybe it's best to only fix that provider so that it actually resizes images instead of just encapsulating them in a OC_Image object?

You could add
$image->fitIn($maxX, $maxY);
to
https://github.com/libasys/core/blob/patch-2/lib/private/preview/image.php#L56

What do you think @georgehrke ?

Also, the test needs fixing and there should be an additional file format, like a psd file, because the providers are not the same.

[libasys]

@oparoz that's a problem of the files app, if you upload a new image in the file app, it automatically creates the 2 images 36&36 px and the max size, or i am wrong?

[oparoz]

When you upload a file, the Preview class will ask the registered provider to provide a preview of the file and that provider should return a preview which fits the max dimensions and keeps the aspect ratio.
The Image provider does not (it doesn't use the given dimension). I should have realised that when writing the tests.

The mechanism is described here: #13607

[LukasReschke]

Unit tests are failing:

08:59:47 There were 3 failures:
08:59:47 
08:59:47 1) Test\Preview::testIsMaxSizeWorking
08:59:47 Failed asserting that 1024 matches expected 640.
08:59:47 
08:59:47 /var/jenkins/workspace/pull-request-analyser-ng-simple/label/SLAVE/tests/lib/preview.php:84
08:59:47 
08:59:47 2) Test\Preview::testIsPreviewDeleted
08:59:47 Failed asserting that true matches expected false.
08:59:47 
08:59:47 /var/jenkins/workspace/pull-request-analyser-ng-simple/label/SLAVE/tests/lib/preview.php:141
08:59:47 
08:59:47 3) Test\Preview::testCreationFromCached
08:59:47 Failed asserting that true matches expected false.
08:59:47 
08:59:47 /var/jenkins/workspace/pull-request-analyser-ng-simple/label/SLAVE/tests/lib/preview.php:222

[libasys]

@oparoz can you fix this issue you are more familiar to the preview class! I think it is really important, cause many users upload pictures to the files app and wondering why there images if the maxX or maxY is greater than the config value are cropped and not resized! Thanks in advance

[oparoz]

OK, I will, but you will miss your opportunity to learn more about that class ;)

[libasys]

lol at the moment i maintain about 7 apps, and make sure that's enough work for myself ;)