Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add occ app:list and ldap:show-config to issue_template.md #16846

Merged
merged 1 commit into from Jul 4, 2015
Merged

Add occ app:list and ldap:show-config to issue_template.md #16846

merged 1 commit into from Jul 4, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2015

Available since OC6 so should be safe to add it.

@ghost
Copy link
Author

ghost commented Jun 9, 2015

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@ghost
Copy link
Author

ghost commented Jun 9, 2015

Just the issue_template.md but anyway: MIT licensed

@MorrisJobke
Copy link
Contributor

👍

@DeepDiver1975
Copy link
Member

  • Should be ownCloud
  • the command is different on various distros - let's add a e.g.

@ghost
Copy link
Author

ghost commented Jun 10, 2015

@DeepDiver1975 Sure, will change that.

Any opinion about the "LDAP configuration" part. This probably can be replaced by:

occ ldap:show-config

or is this command missing some infos which are part of the database query?

@DeepDiver1975
Copy link
Member

I honestly have no clue about ldap @blizzz

@MorrisJobke
Copy link
Contributor

@LukasReschke How is your report app going?

@ghost ghost changed the title Add occ app:list to issue_template.md Add occ app:list and ldap:show-config to issue_template.md Jun 10, 2015
@blizzz
Copy link
Contributor

blizzz commented Jun 10, 2015

@RealRancor yes, the occ command for LDAP please :)

@ghost
Copy link
Author

ghost commented Jun 10, 2015

@blizzz The occ command is only available since OC7 so better leave the sql queries in there?

@MorrisJobke
Copy link
Contributor

👍

@nickvergessen nickvergessen mentioned this pull request Jun 10, 2015
Merged
9 tasks
@MorrisJobke MorrisJobke added this to the 8.2-next milestone Jul 2, 2015
@ghost
Copy link
Author

ghost commented Jul 2, 2015

🚀 Test PASSed.🚀
chuck

RobinMcCorkell
RobinMcCorkell reviewed Jul 4, 2015
View reviewed changes
issue_template.md
then execute: select * from oc_appconfig where appid='user_ldap';

Without access to your command line download the data/owncloud.db to your local
computer or access your SQL server remote and run the select query above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remotely

@RobinMcCorkell
Copy link
Member

Other than the spelling fix, 👍

@scrutinizer-notifier
Copy link

A new inspection was created.

@ghost
Copy link
Author

ghost commented Jul 4, 2015

Thanks for the feedback 👍 Just fixed the spelling.

RobinMcCorkell pushed a commit that referenced this pull request Jul 4, 2015
Merge pull request #16846 from RealRancor/apps_list_issue_template
34637b5 
Add occ app:list and ldap:show-config to issue_template.md
@RobinMcCorkell RobinMcCorkell merged commit 34637b5 into owncloud:master Jul 4, 2015
@ghost ghost deleted the apps_list_issue_template branch July 6, 2015 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review documentation
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@MorrisJobke @DeepDiver1975 @blizzz @RobinMcCorkell @scrutinizer-notifier