Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #17178 #17185

Merged
merged 1 commit into from
Jun 26, 2015
Merged

Fix for #17178 #17185

merged 1 commit into from
Jun 26, 2015

Conversation

rullzer
Copy link
Contributor

@rullzer rullzer commented Jun 25, 2015

Should fix #17178.

The problem was that the submitted POST arguments when empty were considered as strings. not arrays.

Still pretty crappy that testing these ajax files is near impossible :(

CC: @LukasReschke @nickvergessen @PVince81

@rullzer
Fix for #17178
27d5838 
If no array of arrays is submitted make sure we still keep $sharedUsers
and $sharedGroups as arrays so the rest of the code keeps functioning as
it should.
@rullzer rullzer added this to the 8.1-current milestone Jun 25, 2015
@scrutinizer-notifier
Copy link

A new inspection was created.

@ghost
Copy link

ghost commented Jun 25, 2015

🚀 Test PASSed.🚀
chuck

@RobinMcCorkell
Copy link
Member

👍

@MorrisJobke
Copy link
Contributor

Code looks good, that fixes the issue and it still works 👍

MorrisJobke added a commit that referenced this pull request Jun 26, 2015
@MorrisJobke
Merge pull request #17185 from rullzer/fix_17178
569157d 
Fix for #17178
@MorrisJobke MorrisJobke merged commit 569157d into owncloud:master Jun 26, 2015
@rullzer rullzer deleted the fix_17178 branch July 18, 2015 20:02
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature:sharing regression Type:Bug
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

in_array() expects parameter 2 to be array, string given at core/ajax/share.php#296
4 participants
@rullzer @scrutinizer-notifier @RobinMcCorkell @MorrisJobke