-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mimetypealiases.json to mimetypealiases.dist.json #17509
Conversation
@@ -3,6 +3,9 @@ | |||
"_comment2": "./occ maintenance:mimetypesjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line above this (_comment
) needs to be edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks!
👍 |
A new inspection was created. |
Rebased! |
👍 |
@rullzer Can you write the documentation for this feature and propose it as a PR in the documentation repo? Thanks :) |
@MorrisJobke owncloud-archive/documentation#1307 it is high on my todo list |
Move mimetypealiases.json to mimetypealiases.dist.json
Make sure that users can keep their changes in mimetypealiases.json so we can override mimetypealiases.dist.json.
Similar to the last commit in #17481
This way they'll know not to touch the file we distribute.
CC: @PVince81 @Xenopathic @oparoz @MorrisJobke