Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mimetypealiases.json to mimetypealiases.dist.json #17509

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Move mimetypealiases.json to mimetypealiases.dist.json #17509

merged 1 commit into from
Jul 10, 2015

Conversation

rullzer
Copy link
Contributor

@rullzer rullzer commented Jul 8, 2015

Make sure that users can keep their changes in mimetypealiases.json so we can override mimetypealiases.dist.json.
Similar to the last commit in #17481

This way they'll know not to touch the file we distribute.

CC: @PVince81 @Xenopathic @oparoz @MorrisJobke

@rullzer rullzer added this to the 8.2-current milestone Jul 8, 2015
@@ -3,6 +3,9 @@
"_comment2": "./occ maintenance:mimetypesjs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line above this (_comment) needs to be edited

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

@RobinMcCorkell
Copy link
Member

👍

@scrutinizer-notifier
Copy link

A new inspection was created.

@rullzer
Copy link
Contributor Author

rullzer commented Jul 10, 2015

Rebased!

@PVince81
Copy link
Contributor

👍

@MorrisJobke
Copy link
Contributor

@rullzer Can you write the documentation for this feature and propose it as a PR in the documentation repo? Thanks :)

@rullzer
Copy link
Contributor Author

rullzer commented Jul 10, 2015

@MorrisJobke owncloud-archive/documentation#1307 it is high on my todo list

@ghost
Copy link

ghost commented Jul 10, 2015

🚀 Test PASSed.🚀
chuck

rullzer pushed a commit that referenced this pull request Jul 10, 2015
Move mimetypealiases.json to mimetypealiases.dist.json
@rullzer rullzer merged commit 4806d75 into owncloud:master Jul 10, 2015
@rullzer rullzer deleted the mimetype-alias-dist branch July 10, 2015 09:44
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants