Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default 'forwarded for' headers for reverse proxy #17868

Merged
merged 2 commits into from
Aug 11, 2015

Conversation

RobinMcCorkell
Copy link
Member

The vast majority of use cases of reverse proxy functionality will be with the 'X-Forwarded-For' HTTP header, so this PR sets that as the default. It will continue to be restricted by trusted_proxies, so there is no additional security impact.

Also adds a basic setup check to highlight any glaring issues an admin might have. It can be extended later if necessary.

Requires owncloud-archive/documentation#1361 for doc link. Go review it 😄

Spoke to @LukasReschke about security, he said it's OK as long as it is documented properly ^^

@ghost
Copy link

ghost commented Jul 25, 2015

🚀 Test PASSed.🚀
chuck

@karlitschek
Copy link
Contributor

looks good to me 👍

@LukasReschke
Copy link
Member

Will test tomorrow.

@LukasReschke LukasReschke self-assigned this Jul 26, 2015
@MorrisJobke MorrisJobke added this to the 8.2-current milestone Jul 27, 2015
@RobinMcCorkell
Copy link
Member Author

@LukasReschke How did your test go? 🙈

@RobinMcCorkell
Copy link
Member Author

@LukasReschke ping

@LukasReschke
Copy link
Member

Sorry. Simply forgot to feedback here. Works as advertised. Needs rebased though 😄 👍

@DeepDiver1975
Copy link
Member

rebased ...

@RobinMcCorkell
Copy link
Member Author

@DeepDiver1975 Thanks 😄

@ghost
Copy link

ghost commented Aug 10, 2015

💣 Test FAILed. 💣
nooo432

@RobinMcCorkell
Copy link
Member Author

18:18:33 PhantomJS 1.9.8 (Linux 0.0.0) OC.SetupChecks tests checkSetup should return an error if the php version is no longer supported FAILED
18:18:33    Expected [ 'Your PHP version (5.4.0) is no longer <a href="https://secure.php.net/supported-versions.php">supported by PHP</a>. We encourage you to upgrade your PHP version to take advantage of performance and security updates provided by PHP.', 'The reverse proxy headers configuration is incorrect, or you are accessing ownCloud from a trusted proxy. If you are not accessing ownCloud from a trusted proxy, this is a security issue and can allow an attacker to spoof their IP address as visible to ownCloud. Further information can be found in our <a href="{docLink}">documentation</a>.' ] to equal [ 'Your PHP version (5.4.0) is no longer <a href="https://secure.php.net/supported-versions.php">supported by PHP</a>. We encourage you to upgrade your PHP version to take advantage of performance and security updates provided by PHP.' ].
18:18:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@3/label/SLAVE/core/js/tests/specs/setupchecksSpec.js:206

@scrutinizer-notifier
Copy link

A new inspection was created.

@ghost
Copy link

ghost commented Aug 10, 2015

🚀 Test PASSed.🚀
chuck

DeepDiver1975 added a commit that referenced this pull request Aug 11, 2015
Set default 'forwarded for' headers for reverse proxy
@DeepDiver1975 DeepDiver1975 merged commit aed068b into master Aug 11, 2015
@DeepDiver1975 DeepDiver1975 deleted the x-forwarded-for branch August 11, 2015 12:02
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants