[WIP] Share dialog files sidebar #18078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is possible to set a negative number of days in which a public share expires. This results in public sharing not working and it undesired. Weird thing is that the API still lets you create shares and gives back an URL. However the id is "unkown" and the URL invalid.
Storage status is saved in the database. Failed storages are rechecked every 10 minutes, while working storages are rechecked every request. Using the files_external app will recheck all external storages when the settings page is viewed, or whenever an external storage is saved.
This usually doesn't cause issues, but in unit tests sometimes a wrapped storage is passed to Filesystem::mount() and gets rewrapped, hitting the XDebug function nesting level limit when used.
| } | ||
|
|
||
| .shareTabView input[type="text"], .shareTabView input[type="password"] { | ||
| width: 91%; |
There was a problem hiding this comment.
That's some nice precise value you have here 😉
|
Great progress, it already looks much better than the old dialog code 😄 |
|
💣 Test FAILed. 💣 |
| @@ -368,6 +374,21 @@ OC.Share={ | |||
| }); | |||
| }, | |||
| showDropDown:function(itemType, itemSource, appendTo, link, possiblePermissions, filename) { | |||
| var itemModel = new OC.Share.ShareItemModel(itemType, itemSource); | |||
There was a problem hiding this comment.
Here call OC.Share.loadItem() which is still sync ajax, then inject it into the model.
However in the sidebar it needs to be async, so probably need to rewrite another OC.Share.loadItem
blizzz
force-pushed
the
files-rightsidebar
branch
from
1d30248
to
d1439ec
Compare
Adding header support to class OC_OCS_Result
Store storage availability in database
Do not allow invalid default expire days
Add \OCP\ISession to AppFramework
Make sure to hide empty content message when mask is shown
Fix removal of share permissions when share disabled for user
blizzz
force-pushed
the
share-dialog-files-sidebar
branch
from
3347061
to
1e5dcec
Compare
Use the new IteratorDirectory instead of the fakedir wrapper
|
💣 Test FAILed. 💣 |
* This should allow the capabilities to be intergrated into the appframework * Unit tests * Throw exception if closure does not return ICapability instance
* Files * Files_Sharing * Files_Trashbin * Files_Versions
| tagName: 'div', | ||
|
|
||
| initialize: function() { | ||
| if(!this.model instanceof OC.Share.ShareItemModel) { |
There was a problem hiding this comment.
beware that JS cannot detect subclasses this way
There was a problem hiding this comment.
(because there are no subclasses in JS, just prototype duplication)
Basic work for right sidebar
|
The sidebar was merged, you might want to rebase. |
Check if archive contains a directory named like appid
Capabilities manager
|
isaacs/github#18 sigh I will rebase and open a PR against master a little later to-:night_with_stars: |
blizzz
force-pushed
the
share-dialog-files-sidebar
branch
from
155b366
to
09b20f7
Compare
|
This is not the PR you are looking for. You go here #18185 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supposed to implement #17665
currently this is based on files-rightsidebar
cc @PVince81