Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share dialog files sidebar #18185

Merged
merged 59 commits into from
Sep 16, 2015
Merged

Share dialog files sidebar #18185

merged 59 commits into from
Sep 16, 2015

Commits on Sep 16, 2015

  1. refactor share dialog for multi-purpose use (dropdown, sidebar) and b… 

    …etter maintainability
    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    edd163a View commit details
    Browse the repository at this point in the history

  2. share dialog view takes advantage of OC.Backbone.View

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    e7b5921 View commit details
    Browse the repository at this point in the history

  3. remove possibly unreliable code and fix JSdoc

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    ea6e380 View commit details
    Browse the repository at this point in the history

  4. started to port the Model to Backbone`s

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    1651b82 View commit details
    Browse the repository at this point in the history

  5. model now extends Backbone's model and isadjusted

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    7971bc1 View commit details
    Browse the repository at this point in the history

  6. make loadItems work async if a callback is provided 

    not beautiful, but good enough. share.js will not be around too much longer.
    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    e6edc3e View commit details
    Browse the repository at this point in the history

  7. switch to async item loading, take care stuff is updated subsequently

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    97b5fe0 View commit details
    Browse the repository at this point in the history

  8. improve reshare rendering part and move permission calculation to model

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    b015eff View commit details
    Browse the repository at this point in the history

  9. further work on reimplementing the dialog layout

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    83d91dd View commit details
    Browse the repository at this point in the history

  10. move remaining global settings to configModel

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    a57ff13 View commit details
    Browse the repository at this point in the history

  11. improve doc

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    e3fd96f View commit details
    Browse the repository at this point in the history

  12. show tooltips and load avatar

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    1bd6942 View commit details
    Browse the repository at this point in the history

  13. split ShareDialogResharerInfoView from base view

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    dcb084a View commit details
    Browse the repository at this point in the history

  14. ShareDialogResharerInfoView improvements

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    277b786 View commit details
    Browse the repository at this point in the history

  15. split off linkShareView

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    f9c232c View commit details
    Browse the repository at this point in the history

  16. split off expirationView

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    ffd4e0d View commit details
    Browse the repository at this point in the history

  17. less stupid initalization of subviews

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    8f38841 View commit details
    Browse the repository at this point in the history

  18. integraton noshare part into ShareDialogLinkShareView

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    6af6024 View commit details
    Browse the repository at this point in the history

  19. Add share dialog into share tab

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    018d07b View commit details
    Browse the repository at this point in the history

  20. Fix share permissions for share tab

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    f709022 View commit details
    Browse the repository at this point in the history

  21. simplification, and throwing where throwing is needed

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    fdb9561 View commit details
    Browse the repository at this point in the history

  22. no auto-fetch in model

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    f2fb20e View commit details
    Browse the repository at this point in the history

  23. set default value and remove now superflous method

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    755d401 View commit details
    Browse the repository at this point in the history

  24. cleanup

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    f62a3be View commit details
    Browse the repository at this point in the history

  25. started to implement sharee list view. not completed yet, do not cry … 

    …please.
    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    c17d022 View commit details
    Browse the repository at this point in the history

  26. continue to reimplement sharee list view. still WIP

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    5db1db3 View commit details
    Browse the repository at this point in the history

  27. sharee list view: better handle collections

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    44ecdde View commit details
    Browse the repository at this point in the history

  28. old OC.Share.addShareWith now reimplemented

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    60abfcd View commit details
    Browse the repository at this point in the history

  29. fixed set of possible permissions for remote shares

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    5dc2c35 View commit details
    Browse the repository at this point in the history

  30. show link share

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    ce1b0c6 View commit details
    Browse the repository at this point in the history

  31. display expiration info

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    858a2a4 View commit details
    Browse the repository at this point in the history

  32. now you even can share

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    258a2e2 View commit details
    Browse the repository at this point in the history

  33. remove obsolete file action

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    5fad379 View commit details
    Browse the repository at this point in the history

  34. format groups and remotes in autocomplete list

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    4c702aa View commit details
    Browse the repository at this point in the history

  35. share and unshare via link (not yet password). also some internal cha… 

    …nges to reduce unnecessary rendering
    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    f29b516 View commit details
    Browse the repository at this point in the history

  36. mark url on click

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    5dfaa0c View commit details
    Browse the repository at this point in the history

  37. implements setting and removing password for link shares, including f… 

    …orced ones
    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    9fe6d7c View commit details
    Browse the repository at this point in the history

  38. fix allow upload checkbox appeareance

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    6d83235 View commit details
    Browse the repository at this point in the history

  39. make 'Allow editing' (aka public upload) checkbox work

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    7ae84e0 View commit details
    Browse the repository at this point in the history

  40. make unshare work

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    a5b0ea0 View commit details
    Browse the repository at this point in the history

  41. cleanup

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    d4bbc06 View commit details
    Browse the repository at this point in the history

  42. toggle visibility of detailed cruds permissions

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    c7453b4 View commit details
    Browse the repository at this point in the history

  43. make permission/cruds checkboxes work

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    a0fa718 View commit details
    Browse the repository at this point in the history

  44. cleanup

    @blizzz
    blizzz authored and Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    c2ff2ca View commit details
    Browse the repository at this point in the history

  45. Add expiration date handling in share tab

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    8194d09 View commit details
    Browse the repository at this point in the history

  46. Bring back the share icon and update its status 

    Display share icon in file list row.
Update share icon status when the sharing state changed.
    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    e900658 View commit details
    Browse the repository at this point in the history

  47. Fix shares list events 

    Some events need preventing default like unshare, but setting
permissions doesn't.
    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    06b11dd View commit details
    Browse the repository at this point in the history

  48. Clear field after adding user

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    e0a2004 View commit details
    Browse the repository at this point in the history

  49. Implement "notify by email" checkbox in share dialog

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    aeee19b View commit details
    Browse the repository at this point in the history

  50. Implement email share link

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    62ff787 View commit details
    Browse the repository at this point in the history

  51. Implement email autocomplete for link share

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    1933bcf View commit details
    Browse the repository at this point in the history

  52. Remove unused/obsoleted OC.Share code 

    The sharing dialog has been moved to ShareDialogView
    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    41f16e8 View commit details
    Browse the repository at this point in the history

  53. Update JS unit tests for share dialog (WIP)

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    886f1ed View commit details
    Browse the repository at this point in the history

  54. More unit tests for share dialog

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    996639f View commit details
    Browse the repository at this point in the history

  55. Fix allow reshare for owner when sharing with self through group

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    f439c07 View commit details
    Browse the repository at this point in the history

  56. Removed obsolete tests

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    02d68d0 View commit details
    Browse the repository at this point in the history

  57. Fix cruds button in share dialog 

    Only toggle the current row
    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    36e452a View commit details
    Browse the repository at this point in the history

  58. Port share.css styles to the sidebar panel

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    6141ea1 View commit details
    Browse the repository at this point in the history

  59. Properly show sidebar when clicking on share button

    Vincent Petry committed Sep 16, 2015
    Configuration menu
    Copy the full SHA
    e7e0cfe View commit details
    Browse the repository at this point in the history