occ commands to manage logging #18369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool and useful!! 👍 |
|
It'd be nice if the CI build slave didn't shutdown while testing this... I'll try again in the morning. |
|
|
@DeepDiver1975 STOP PLAYING AROUND WITH THE CI SYSTEM! |
| if (is_numeric($level)) { | ||
| $levelNum = $level; | ||
| // sanity check | ||
| $level = $this->convertLevelNumber($levelNum); |
|
I'd like to see unit test on these new commands - THX |
added 3 commits
August 19, 2015 12:33
log:manage can set/display the log backend, log level and log timezone
log:owncloud can set/display the log filename and log file rotation size
RobinMcCorkell
force-pushed
the
occ-log
branch
from
8fb12fb
to
2663f12
Compare
|
A new inspection was created. |
| @@ -493,9 +493,10 @@ | |||
| 'log_type' => 'owncloud', | |||
|
|
|||
| /** | |||
| * Change the ownCloud logfile name from ``owncloud.log`` to something else. | |||
There was a problem hiding this comment.
@carlaschroder please review these changes since the will be re-used in the documentation
|
🚀 Test PASSed.🚀 |
|
👍 Now all I'm missing is another command "./occ log:human" that outputs the log in a properly formatted way, with nicely presented stack traces (I'm tired of manually reformatting stack traces in bug reports) |
|
@PVince81 Getting there 😄 |
|
Tested and works 👍 |
MorrisJobke
added a commit
that referenced
this pull request
Aug 20, 2015
occ commands to manage logging
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In similar vein to the maintenance:* commands and others, this PR introduces two new occ commands, log:manage and log:owncloud. It takes away the requirement to look at the documentation to change logging settings.
log:manage allows the following information to be set/displayed: logging backend (owncloud, errorlog, syslog), log level and log timezone.
log:owncloud manages the owncloud logging backend, and can be used to set/display: log filename and log rotation size. These are parameters specific to the owncloud backend, and so get their own command
@PVince81 we discussed this briefly
cc @DeepDiver1975 @MorrisJobke @LukasReschke