Migrate simple external storage backends to new registration API [part 1] #18432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 19, 2015 14:20
Introduces the basic password authentication mechanism, along with a mechanism based on ownCloud credentials stored in the user session. Change to lib/private is an extension of PermissionsMask, as isSharable() override was missing. Session credentials auth mechanism now disables sharing on applied storages, as credentials will not be available.
The builtin mechanism is used exclusively for legacy external storages, which when upgraded to the new registration need to fallback to the defined legacy authentication mechanism instead.
…ing" This reverts commit 75a5e6e.
|
A new inspection was created. |
|
Thank you @Xenopathic 👍 |
|
🚀 Test PASSed.🚀 |
|
Tested and works 👍
|
MorrisJobke
added a commit
that referenced
this pull request
Aug 19, 2015
Migrate simple external storage backends to new registration API [part 1]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the 'password' authentication scheme, implemented by the basic username/password input and session-based credentials (like SMB_OC worked). As a result, I reverted a (broken) fix for multi-wrapping storages. The fix was only necessary to prevent function nesting overloads in some broken unit tests, if the issue comes up again, I'll fix the unit tests this time.
The following storages have been migrated:
Please review @PVince81 @DeepDiver1975 @MorrisJobke @icewind1991
cc @jmaciasportela for an example of how registration works. These are quite simple, more advanced ones to come.
Replaces #18245