occ config:system:set can now set other value types

[RobinMcCorkell]

Integers, doubles, booleans and even arrays can now be set, with the --type=... option. Array setting can be specified by passing multiple name arguments, e.g. ./occ config:system:set redis port --value=123 --type=integer

Fixes #17687

cc @nickvergessen @DeepDiver1975 @MorrisJobke

[scrutinizer-notifier]

A new inspection was created.

[nickvergessen]

How do you do nested arrays? See oobjecttstore array in the sample config

[RobinMcCorkell]

./occ config:system:set objectstore arguments autocreate --value=true --type=bool

[nickvergessen]

@Xenopathic well int, bool and null is nice!

But array still lacks nesting support. Please post a command that writes the following to the config:
https://github.com/owncloud/core/blob/master/config/config.sample.php#L898-L920

[RobinMcCorkell]

@nickvergessen It would be next to impossible to get a command-line syntax to set an entire array at once, that's why I decided to treat array values as subsections almost. So you set each sub-value individually:

./occ config:system:set objectstore class --value='OC\\Files\\ObjectStore\\Swift'
./occ config:system:set objectstore arguments username --value='facebook100000123456789'
./occ config:system:set objectstore arguments password --value='Secr3tPaSSWoRdt7'
./occ config:system:set objectstore arguments container --value='owncloud'
./occ config:system:set objectstore arguments autocreate --value=true --type=bool
./occ config:system:set objectstore arguments region --value='RegionOne'
./occ config:system:set objectstore arguments url --value='http://8.21.28.222:5000/v2.0'
./occ config:system:set objectstore arguments tenantName --value='facebook100000123456789'
./occ config:system:set objectstore arguments serviceName --value='swift'

Imagine trying to set that in a single command line?

[nickvergessen]

yeah well, I guess that works as well. Should have that on delete too then?

The only other idea I could imagine would be json_encode(), but I guess that's too difficult to achieve, so your solution seems better, just needs proper documentation adjustments:
https://github.com/owncloud/documentation/blob/master/admin_manual/configuration_server/occ_command.rst#config-commands

[RobinMcCorkell]

Well, TBH I think all 3 commands (get, set, delete) should be merged into one command. The way it would work is like this:

• ./occ config:system option returns the value of the config parameter 'option'
• ./occ config:system option --set=foobar sets the value of the config parameter 'option' to 'foobar'
• ./occ config:system option --delete deletes the config parameter 'option'

For an example that is already in master, see the new ./occ log:manage command: https://github.com/owncloud/core/blob/master/core/command/log/manage.php. It uses the system I just described above (without delete of course, that doesn't make sense for log configuration).

I could implement that in this PR if you'd like? Then another PR to move config:app over too?

[RobinMcCorkell]

Perhaps not for 8.2 😄

[MorrisJobke]

@cmonteroluque @DeepDiver1975 Do we want this in 8.2? On the one hand the code is ready - on the other hand it is only a sev3 ticket and an enhancement.

[nickvergessen]

wrong intendation

[RobinMcCorkell]

@MorrisJobke Also, this brings inconsistencies between config:system:set and the other config:system:* commands. I proposed merging all the commands into a central config:system (with compatibility for the then-legacy commands) but it was never implemented...

[ghost]

@Xenopathic @MorrisJobke cool

[PVince81]

The problem now is that if we decide to change the behavior or remove commands, these need to be deprecated first, because some admins might have already started using these in scripts. So it would qualify as public API.

[nickvergessen]

• Rebased
• Restored BC for set
• Added nested support to delete
• Added nested support to get

[nickvergessen]

@Xenopathic @MorrisJobke please reviews

[LukasReschke]

Works 👍

[MorrisJobke]

Tested and works 👍