Introduce mimetype DB update occ command #18742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good idea 👍 |
|
👍 code looks good, saw it work |
|
Looking good! But we really should have tests for this as well (I know I did not write them either...) |
| $application->add(new OC\Core\Command\Maintenance\Mode(\OC::$server->getConfig())); | ||
| $application->add(new OC\Core\Command\Maintenance\Repair(new \OC\Repair(\OC\Repair::getRepairSteps()), \OC::$server->getConfig())); | ||
| $application->add(new OC\Core\Command\Maintenance\SingleUser(\OC::$server->getConfig())); | ||
| $application->add(new OC\Core\Command\Maintenance\Mimetype\UpdateJS(\OC::$server->getMimeTypeDetector())); |
There was a problem hiding this comment.
You mean like the rest of the file is? 😆
RobinMcCorkell
force-pushed
the
mimetype-updatedb
branch
from
08390d9
to
d5bff40
Compare
RobinMcCorkell
force-pushed
the
mimetype-updatedb
branch
2 times, most recently
from
e38039d
to
f6355b3
Compare
|
Well, doing it properly turned out to be a lot more work than expected, but at least some code smell has been removed. Everything is unit tested too |
RobinMcCorkell
force-pushed
the
mimetype-updatedb
branch
from
f6355b3
to
c6314fc
Compare
|
A new inspection was created. |
|
Looks good 👍 |
|
Looks good and everything seems to work. 👍 |
rullzer
added a commit
that referenced
this pull request
Sep 6, 2015
Introduce mimetype DB update occ command
|
Awesome! :) |
|
But I like code smell. It smells like victory. |
|
Regression: master unit tests are broken: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occ command allows mimetypes in the database to be updated from changed mimetypes in config/mimetypemapping.json. By default, it adds any new mimetypes it finds and updates the filecache based on those, but with an option it can scan all existing mimetypes to update mimetypes on files.
For example, you add a new mapping of '.foo' to 'application/foobar', but your existing '.foo' files still have the 'application/octet-stream' mimetype since they were uploaded before. Run
./occ maintenance:mimetype:update-dbto update this. Or, if the 'application/foobar' mimetype already existed,./occ maintenance:mimetype:update-db --repair-filecache(will be a lot slower for big filecaches!).Please review @rullzer @icewind1991 @MorrisJobke @PVince81 @icewind1991 @DeepDiver1975
cc @carlaschroder for documentation around the new occ command, and rename of the maintenance:mimetypesjs command to maintenance:mimetype:update-js
Fixes #17625