Use "json_encode" and "json_decode" instead of unserialize

[LukasReschke]

@blizzz Please review.

Fixes #16498

[scrutinizer-notifier]

A new inspection was created.

[RobinMcCorkell]

👍👍👍👍👍👍👍👍

[blizzz]

@LukasReschke migration?

[LukasReschke]

@blizzz As far I see this uses the memcache, if you update to a new release the caching keys will have a new prefix (including the version) and thus there is no migration required.

[blizzz]

@LukasReschke never mind. I mixed it up, overnight, with settings. I give it a practical try later, so far stuff looks good.

[MorrisJobke]

Tested and still works with LDAP. 👍

[MorrisJobke]

@LukasReschke @blizzz Would it make sense to backport this to stable8.1 to mitigate the unserialize issue in https://github.com/owncloud/enterprise/issues/1094? Or is this too risky?

[blizzz]

@MorrisJobke if you include the other fix (the missing true), it's low risk.

[MorrisJobke]

@MorrisJobke if you include the other fix (the missing true), it's low risk.

Sure. I just think about migration implications.

@LukasReschke After an upgrade the cache gets cleared completely, right?

[MorrisJobke]

@LukasReschke After an upgrade the cache gets cleared completely, right?

Or better: it will use the version for cached entries and therefore not reuse the cache that was created before the update. Is this correct?

[MorrisJobke]

Regression fix: #21999

[MorrisJobke]

@MorrisJobke if you include the other fix (the missing true), it's low risk.

#22632

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.