Fix get_temp_dir compat shim #19023
Closed
Fix get_temp_dir compat shim #19023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new inspection was created. |
|
A search in core reveals that this function is only used in office preview - I vote for dropping the function in base.php and fix office preview |
|
@DeepDiver1975 Do we assume that no apps use this? The compat shim isn't very much overhead to keep... |
Merged
|
@DeepDiver1975 Alternative approach in #19024. Pick one, close the other 😄 |
They are not allowed to use it - this function was never near any public api specification |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #18658 we moved the code to TempManager, but inadvertently moved the function
get_temp_dir()from the global namespace to the OC class. This moves it back, and fixes an incorrect function call.cc @DeepDiver1975 @MorrisJobke @mmattel
Fixes #19021