Don't mock the ISecure

[hutchic]

Should get #18485 tests passing

Mocked ISecure leads to a fatal error when user controller calls

$this->secureRandom->getMediumStrengthGenerator()->generate( ... )

I didn't see any reason this needed to be mocked so I nuked the mock

[MorrisJobke]

cc @LukasReschke

[LukasReschke]

I'd prefer a proper unit test instead of removing it completely. You basically need to do some more mocking here. Checkout

core/tests/core/lostpassword/controller/lostcontrollertest.php

Lines 189 to 208 in 2479363

	$randomToken = $this->container['SecureRandom'];
	$this->container['SecureRandom']
	->expects($this->once())
	->method('generate')
	->with('21')
	->will($this->returnValue('ThisIsMaybeANotSoSecretToken!'));
	$this->container['UserManager']
	->expects($this->once())
	->method('userExists')
	->with('ExistingUser')
	->will($this->returnValue(true));
	$this->container['Config']
	->expects($this->once())
	->method('getUserValue')
	->with('ExistingUser', 'settings', 'email')
	->will($this->returnValue('test@example.com'));
	$this->container['SecureRandom']
	->expects($this->once())
	->method('getMediumStrengthGenerator')
	->will($this->returnValue($randomToken));

for reference.

👎 from my side for this approach.