Introduce console command to transfer ownerships of files #20571

DeepDiver1975 · 2015-11-18T12:16:17Z

refs #19154

Requires Sharing 2.0 to implement getShares() and updateShare()

@schiesbn @rullzer

karlitschek · 2015-11-18T12:19:01Z

nice! 👍

DeepDiver1975 · 2016-01-07T19:22:58Z

@rullzer still waiting for getshares to be implemented 😉

rullzer · 2016-01-07T19:58:44Z

@DeepDiver1975 it is on the todo... and a lot closer to happening now that createShares is in ;)

DeepDiver1975 · 2016-01-07T20:05:42Z

@DeepDiver1975 it is on the todo... and a lot closer to happening now that createShares is in ;)

great!

karlitschek · 2016-01-07T20:23:51Z

@msrex

rullzer · 2016-02-01T09:26:03Z

Looks good. Did some testing and it seems to all work.

However I would very much like to have intergration tests for this... since I do assume there are corner cases where restoring shares will fail. Because it creates a duplicated share or whatever...

rullzer · 2016-02-01T09:30:38Z

apps/files/command/transferownership.php

+			if ($share->getSharedWith() === $destinationUser) {
+				$this->shareManager->deleteShare($share);
+			} else {
+				$share->setShareOwner($destinationUser);


This is not correct.
The share owner might be a different user then we are migrating.

So I only update the share owner in case the current owner is the user from whom we are moving away?

yes. Basically we get the file from the fileid in the owners folder... so if that is not set correctly.... 💥

rullzer · 2016-02-01T09:45:22Z

So you copy the files from sourceUser to destUser. I get this. But this break the chain of shares. Since the fileId changes.

So assume.

user1 shares foo with user2
user2 shares foo with user3
transfer ownership of user2 to user4.

Now all of a sudden the incomming share foo for user3 no longer is the same foo as user1 shared originally.

DeepDiver1975 · 2016-02-01T09:46:56Z

apps/files/command/transferownership.php

+	protected function transfer(OutputInterface $output) {
+		$view = new View();
+		$output->writeln("Transferring files to $this->finalTarget ...");
+//		$view->rename("$this->sourceUser/files", $this->finalTarget);


@rullzer rename is to be used - not copy. I use copy for testing - will fix asap

DeepDiver1975 · 2016-02-01T10:03:02Z

So you copy the files from sourceUser to destUser.

it's a move ....

MorrisJobke · 2016-02-05T19:22:26Z

@DeepDiver1975 Ready for review?

PVince81 · 2016-02-08T15:44:49Z

Tested, works now 👍

PVince81 · 2016-02-08T15:45:58Z

Second reviewer ? @rullzer @icewind1991 @MorrisJobke @nickvergessen

PVince81 · 2016-02-08T16:31:18Z

or @LukasReschke ?

rullzer · 2016-02-08T20:25:12Z

apps/files/command/transferownership.php

+	private function restoreShares(OutputInterface $output) {
+		$output->writeln("Restoring shares ...");
+		$progress = new ProgressBar($output, count($this->shares));
+		/** @var Folder $sourceRoot */


This can go

rullzer · 2016-02-08T20:32:33Z

Ran some tests and they passed.

I would recommend to add to the docs a big warning to backup their data. I do think there will still be corner cases where things might say boom.

Also it would be very nice if we could setup intergration tests for this.

My nitpickings aside.. 👍

nickvergessen · 2016-02-09T10:08:29Z

apps/files/command/transferownership.php

+	public function __construct(IUserManager $userManager, IManager $shareManager, IRootFolder $rootFolder) {
+		$this->userManager = $userManager;
+		$this->shareManager = $shareManager;
+		$this->rootFolder = $rootFolder;


This is unused

DeepDiver1975 · 2016-02-09T14:43:09Z

@icewind1991 description updated - please have a look

icewind1991 · 2016-02-09T15:10:29Z

Code looks good 👍

Introduce console command to transfer ownerships of files

DeepDiver1975 added the 2 - Developing label Nov 18, 2015

DeepDiver1975 added this to the 9.0-current milestone Nov 18, 2015

DeepDiver1975 added the in progress label Nov 18, 2015

PVince81 added the comp:core label Nov 20, 2015

DeepDiver1975 force-pushed the transfer-ownership branch 2 times, most recently from 3e24ada to 5428e88 Compare November 26, 2015 16:12

DeepDiver1975 force-pushed the transfer-ownership branch from 5428e88 to 6a60481 Compare December 2, 2015 15:18

DeepDiver1975 force-pushed the transfer-ownership branch 2 times, most recently from 7208a13 to 89546bb Compare December 18, 2015 07:01

DeepDiver1975 force-pushed the transfer-ownership branch from 89546bb to 0e6bfee Compare January 7, 2016 19:22

DeepDiver1975 force-pushed the transfer-ownership branch 3 times, most recently from b536396 to cdb5e18 Compare January 22, 2016 10:12

DeepDiver1975 force-pushed the transfer-ownership branch 3 times, most recently from 72c699a to 477c7fd Compare January 29, 2016 16:00

DeepDiver1975 changed the title ~~[WIP] Introduce console command to transfer ownerships of files~~ Introduce console command to transfer ownerships of files Jan 29, 2016

DeepDiver1975 added 3 - To Review and removed 2 - Developing labels Jan 29, 2016

rullzer reviewed Feb 1, 2016
View reviewed changes

DeepDiver1975 reviewed Feb 1, 2016
View reviewed changes

DeepDiver1975 force-pushed the transfer-ownership branch from 477c7fd to 3ab0a3f Compare February 1, 2016 09:49

DeepDiver1975 force-pushed the transfer-ownership branch 3 times, most recently from 411a45e to 7e33e67 Compare February 8, 2016 14:54

DeepDiver1975 added 3 - To Review and removed 2 - Developing labels Feb 8, 2016

rullzer reviewed Feb 8, 2016
View reviewed changes

DeepDiver1975 force-pushed the transfer-ownership branch from 0508d83 to e16dc3a Compare February 9, 2016 09:32

nickvergessen reviewed Feb 9, 2016
View reviewed changes

DeepDiver1975 force-pushed the transfer-ownership branch from e16dc3a to f09edde Compare February 9, 2016 13:26

DeepDiver1975 added 3 commits February 9, 2016 15:41

Introduce console command to transfer ownerships of files - refs #19154

cbb7934

Set share owner and share initiator on upate as well

10b9bf1

Adjust command description

81d4042

DeepDiver1975 force-pushed the transfer-ownership branch from f09edde to 81d4042 Compare February 9, 2016 14:42

DeepDiver1975 added a commit that referenced this pull request Feb 9, 2016

Merge pull request #20571 from owncloud/transfer-ownership

ac08540

Introduce console command to transfer ownerships of files

DeepDiver1975 merged commit ac08540 into master Feb 9, 2016

DeepDiver1975 deleted the transfer-ownership branch February 9, 2016 15:11

DeepDiver1975 removed the in progress label Feb 9, 2016

lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce console command to transfer ownerships of files #20571

Introduce console command to transfer ownerships of files #20571

DeepDiver1975 commented Nov 18, 2015

karlitschek commented Nov 18, 2015

DeepDiver1975 commented Jan 7, 2016

rullzer commented Jan 7, 2016

DeepDiver1975 commented Jan 7, 2016

karlitschek commented Jan 7, 2016

rullzer commented Feb 1, 2016

rullzer Feb 1, 2016

DeepDiver1975 Feb 1, 2016

rullzer Feb 1, 2016

rullzer commented Feb 1, 2016

DeepDiver1975 Feb 1, 2016

rullzer Feb 1, 2016

DeepDiver1975 commented Feb 1, 2016

MorrisJobke commented Feb 5, 2016

PVince81 commented Feb 8, 2016

PVince81 commented Feb 8, 2016

PVince81 commented Feb 8, 2016

rullzer Feb 8, 2016

rullzer commented Feb 8, 2016

nickvergessen Feb 9, 2016

DeepDiver1975 commented Feb 9, 2016

icewind1991 commented Feb 9, 2016

Introduce console command to transfer ownerships of files #20571

Introduce console command to transfer ownerships of files #20571

Conversation

DeepDiver1975 commented Nov 18, 2015

karlitschek commented Nov 18, 2015

DeepDiver1975 commented Jan 7, 2016

rullzer commented Jan 7, 2016

DeepDiver1975 commented Jan 7, 2016

karlitschek commented Jan 7, 2016

rullzer commented Feb 1, 2016

rullzer Feb 1, 2016

Choose a reason for hiding this comment

DeepDiver1975 Feb 1, 2016

Choose a reason for hiding this comment

rullzer Feb 1, 2016

Choose a reason for hiding this comment

rullzer commented Feb 1, 2016

DeepDiver1975 Feb 1, 2016

Choose a reason for hiding this comment

rullzer Feb 1, 2016

Choose a reason for hiding this comment

DeepDiver1975 commented Feb 1, 2016

MorrisJobke commented Feb 5, 2016

PVince81 commented Feb 8, 2016

PVince81 commented Feb 8, 2016

PVince81 commented Feb 8, 2016

rullzer Feb 8, 2016

Choose a reason for hiding this comment

rullzer commented Feb 8, 2016

nickvergessen Feb 9, 2016

Choose a reason for hiding this comment

DeepDiver1975 commented Feb 9, 2016

icewind1991 commented Feb 9, 2016