Don't load commands of apps when in maintenance mode

[DeepDiver1975]

fixes #20939

[mention-bot]

By analyzing the blame information on this pull request, we identified @mmattel, @MorrisJobke and @LukasReschke to be potential reviewers

[DeepDiver1975]

@karlitschek this can happen on previous version of ownCloud as well

[karlitschek]

Wow. Didn't we fix this before? Strange.
Backport makes sense 👍

[DeepDiver1975]

Wow. Didn't we fix this before? Strange.

no - we did fix it for the upgrade case - but not if the instance stays in maintenance mode afterwards

[PVince81]

👍

[DeepDiver1975]

preparing backports ....

[RobinMcCorkell]

As an admin, I want to be able to modify my LDAP configuration and external storages, re-scan the filesystem and do other maintenance stuff while my instance is in maintenance mode. Can I still do that?

[MorrisJobke]

As an admin, I want to be able to modify my LDAP configuration and external storages, re-scan the filesystem and do other maintenance stuff while my instance is in maintenance mode. Can I still do that?

Changing LDAP stuff is not possible, because it is an app.

[MorrisJobke]

The other mentioned stuff is possible

[RobinMcCorkell]

@MorrisJobke But that would be one of the main reasons I would put my instance into maintenance mode, to adjust critical settings such as LDAP!

[MorrisJobke]

@MorrisJobke But that would be one of the main reasons I would put my instance into maintenance mode, to adjust critical settings such as LDAP!

It's boon and bane of the apps. We either enable them and they cause trouble because the instance is in maintenance mode or we can disable them and then their functionality is missing.

[RobinMcCorkell]

@MorrisJobke As I pointed out right at the beginning (#20939 (comment)) the problem isn't with the apps, it's with our app loader mechanism.

[MorrisJobke]

@MorrisJobke As I pointed out right at the beginning (#20939 (comment)) the problem isn't with the apps, it's with our app loader mechanism.

Ah. Now it makes sense. Okay - why is this mechanism in place there? I guess it has a reason ;)

[RobinMcCorkell]

@MorrisJobke From what I can tell, it's a basic hack to stop ownCloud from loading apps while in maintenance mode, since they (usually) aren't needed. Except when using occ to perform maintenance on an app. The easiest way to solve it, as I mentioned, is to call loadApp() on each installed app individually when we load app commands, rather than rely on loadApps() to do all of it for us.