Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move controller in core/ to a common subfolder #21797

Merged
merged 4 commits into from
Jan 21, 2016

Conversation

MorrisJobke
Copy link
Contributor

  • move avatar controller to core/controller
  • move setup controller to core/controller
  • move user controller to core/controller
  • move lost controller to core/controller

I tested all components and also the password reset stuff. Everything works as before.

cc @PVince81 @LukasReschke @nickvergessen @rullzer @DeepDiver1975

This also makes core/ look a bit more like an app (what it actually is ;)) and clean up the structure of the folder.

* lostpassword.css is unneeded since #11696 is merged - 1b50d4f
* js is already in core/js
* css is moved to core/css/lostpassword
* template is moved to core/templates/lostpassword
@MorrisJobke MorrisJobke added this to the 9.0-current milestone Jan 20, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @rullzer, @LukasReschke and @DeepDiver1975 to be potential reviewers

@rullzer
Copy link
Contributor

rullzer commented Jan 21, 2016

Everything seems to still work.
Nice cleanup. 👍

@LukasReschke
Copy link
Member

👍

DeepDiver1975 added a commit that referenced this pull request Jan 21, 2016
Move controller in core/ to a common subfolder
@DeepDiver1975 DeepDiver1975 merged commit 2b4532c into master Jan 21, 2016
@DeepDiver1975 DeepDiver1975 deleted the proper-controller-in-core branch January 21, 2016 14:20
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants