Fix errors after install #21923
Merged
Fix errors after install #21923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing ownCloud the first time the first thing that an admin saw was an error message: > Error PHP touch(): Unable to create file owncloud.log because Permission denied at /var/www/owncloud/lib/private/log/owncloud.php#48 Or something related. This lead to a lot confusion as can be seen in our forum and in our issue tracker. This change should make the error messages disappear in most cases (e.g. where the file can actually be written). To test this: 1. On master install ownCloud and check owncloud.log => Error message 2. On this branch install ownCloud and check owncloud.log => No error message Fixes #13736 and #12893
|
By analyzing the blame information on this pull request, we identified @bantu, @bartv2 and @nickvergessen to be potential reviewers |
|
Tested and works 👍 |
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Jan 27, 2016
Fix errors after install
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing ownCloud the first time the first thing that an admin saw was an error message:
Or something related. This lead to a lot confusion as can be seen in our forum and in our issue tracker. This change should make the error messages disappear in most cases (e.g. where the file can actually be written). To test this:
ee.config.phpin the config folder that contains:adjust
index.phpto contain something like\OC::$server->getLogger()->critical('yo');so that an error get logged. Ensure that/tmp/yolo.logis used.Fixes #13736 and #12893
@karlitschek Should make you happier as well. Heard you ranting about this some time ago 😉
@MorrisJobke @rullzer @DeepDiver1975 Mind testing?