WebUI feedback when sharing #22350
Merged
WebUI feedback when sharing #22350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #22304 Creating a share is not instant (especially not for federated shares) so we should show that something is happening in the webUI properly.
|
By analyzing the blame information on this pull request, we identified @PVince81, @blizzz and @tomneedham to be potential reviewers |
|
It seems the background of the spinner is not transparent... |
Another one for the #19091 But it is still an improvement. 👍 @owncloud/designers Any idea how to improve the spinner look? |
|
works 👍 |
|
Please create a new issue for the non-transparent spinner issue or use the linked issue from morris |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 15, 2016
WebUI feedback when sharing
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22304
The input field is locked and the spinner is shown.
All is unlocked once it is shared.
CC: @owncloud/designers @owncloud/javascript @nickvergessen