set correct http status code in redirect response

[v1r0x]

Was intended to respond with a 303 (See other) status code instead of 307 (Temporary Redirect).

cc @BernhardPosselt (btw: thanks for the fix! ;))

[mention-bot]

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @MorrisJobke and @BernhardPosselt to be potential reviewers

[nickvergessen]

OCP\AppFramework\Http\RedirectResponseTest::testHeaders
Failed asserting that 303 matches expected 307.
/ssd/jenkins/workspace/server-master-linux-php7-ci/database/sqlite/label/SLAVE/tests/lib/appframework/http/RedirectResponseTest.php:47

You need to adjust the unit test as well,

when you did that, please set the label "To Review"

[BernhardPosselt]

As discussed yesterday on IRC 👍 if unit tests are fixed.

Background: This response was intended to implement the Post/Redirect/Get pattern: https://en.wikipedia.org/wiki/Post/Redirect/Get

[nickvergessen]

https://github.com/owncloud/core/blob/master/tests/lib/appframework/http/RedirectResponseTest.php#L46

[nickvergessen]

👍

[rullzer]

Fine by me. 👍

[oparoz]

This kind of breaking changes has to be advertised on the devel mailing lists.
It breaks tests for all apps which use the AppFramework and which have unit tests.

[nickvergessen]

Well basically can happen with any function that is changed.

[oparoz]

Yes and all such changes should be advertised. We're not talking about private APIs here.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.