Add integration tests for comments #22511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @SergioBertolinSG, @MorrisJobke and @DeepDiver1975 to be potential reviewers |
| Given user "user0" exists | ||
| And As an "user0" | ||
| And User "user0" uploads file "data/textfile.txt" to "/myFileToComment.txt" | ||
| And "User0" posts a comment with content "My first comment" on the file named "/myFileToComment.txt" it should return "201" |
LukasReschke
force-pushed
the
add-integration-tests-for-comments
branch
from
e22fbfb
to
13253a5
Compare
3 tasks
| And the response should contain a property "oc:actorDisplayName" with value "user1" | ||
| And the response should contain only "1" comments | ||
| Then As "user1" delete the created comment it should return "204" | ||
| Then As "user1 load all the comments of the file named "/myFileToComment.txt" it should return "207" |
LukasReschke
force-pushed
the
add-integration-tests-for-comments
branch
2 times, most recently
from
b9a9956
to
d3636d7
Compare
|
I think the base of the gherkin syntax is being forgotten lately, 'given' for preconditions, 'when' for the actual test and 'then' for expected postconditions. Here the scenarios doesn't have a when statement. |
LukasReschke
force-pushed
the
add-integration-tests-for-comments
branch
from
d3636d7
to
f33ee86
Compare
|
@SergioBertolinSG Mind taking another look? THX. |
LukasReschke
force-pushed
the
add-integration-tests-for-comments
branch
from
f33ee86
to
acf81bc
Compare
| And the response should contain a property "oc:message" with value "My first comment" | ||
| And the response should contain a property "oc:actorDisplayName" with value "user1" | ||
| And the response should contain only "1" comments | ||
| Then As "user0" edit the last created comment and set text to "My edited comment" it should return "403" |
|
👍 cool stuff! |
|
Nice 👍 |
This adds integration tests for the comments. Especially with regard to the permission handling, didn't find any problem in it. Fixes #22367
LukasReschke
force-pushed
the
add-integration-tests-for-comments
branch
from
9bb5b46
to
16be9af
Compare
LukasReschke
added a commit
that referenced
this pull request
Feb 19, 2016
…ments Add integration tests for comments
|
Thank you. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds integration tests for the comments. Especially with regard to the permission handling, time to add automated security integration tests to our APIs.
It's not the super nicest approach but it works 😉
Fixes #22367
cc @MorrisJobke @DeepDiver1975 Please review.