[stable9] Chunk upload for GDrive #23361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 17, 2016 16:12
Instead of storing the WHOLE file in memory in a PHP variable, use the library's chunk upload support.
|
By analyzing the blame information on this pull request, we identified @Xenopathic, @MTGap and @icewind1991 to be potential reviewers |
|
@owncloud/qa can you help testing ? |
|
Works fine 👍 A problem with an upload happened once, but not reproducible. Logs here http://paste.debian.net/417740/ |
|
Looks like the error you saw was a connection failed to the GDrive server in the constructor. |
|
@icewind1991 second review ? |
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Mar 22, 2016
[stable9] Chunk upload for GDrive
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #23323 to stable9
Please review @icewind1991 @LukasReschke @schiesbn @Xenopathic @MorrisJobke