Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url encode search query, fix unwanted search on scroll #23531

Closed
wants to merge 1 commit into from

Conversation

butonic
Copy link
Member

@butonic butonic commented Mar 23, 2016

allows sending special chars like ? and *, also prevents sending the old query when adding a single char

allows sending special chars like ? and *, also prevents sending the old query when adding a single char
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @MorrisJobke, @DeepDiver1975 and @Henni to be potential reviewers

@DeepDiver1975 DeepDiver1975 added this to the 9.1-current milestone Mar 24, 2016
@DeepDiver1975
Copy link
Member

@LukasReschke THX

@MorrisJobke
Copy link
Contributor

allows sending special chars like ? and *, also prevents sending the old query when adding a single char

This actually breaks it. In master it is working. In this branch it doesn't work anymore.

  • add a folder abc
  • add a file ?welcome.txt to abc
  • search for ?wel in there root.

@butonic
Copy link
Member Author

butonic commented Mar 24, 2016

well then we need to also url decode the query string in php again.

@PVince81
Copy link
Contributor

CC @georgehrke

@PVince81
Copy link
Contributor

Closing due to lack of activity.
As I see this is a trivial fix so if it's important feel free to reopen and complete the work.

@PVince81 PVince81 closed this May 20, 2016
@PVince81 PVince81 deleted the butonic-patch-1 branch May 20, 2016 15:17
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants