Move public webdav auth to share manager #23736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmmm now the other unit tests fall appart... but why... |
rullzer
force-pushed
the
move_public_webdav_auth_to_share_manager
branch
from
2445414 to
12d938e
Compare
|
The infamous incognito mode strikes again... fixed.. |
|
Ok so apparently I broke one of the intergration tests... will take care. |
rullzer
force-pushed
the
move_public_webdav_auth_to_share_manager
branch
from
12d938e to
bb58642
Compare
|
Ok all should be fine now! Review please |
|
Calling once again on the review team: @PVince81 @schiesbn @DeepDiver1975 @nickvergessen |
| // Set old user | ||
| \OC_User::setUserId($this->oldUser); | ||
| \OC_Util::setupFS($this->oldUser); | ||
| } |
There was a problem hiding this comment.
missing parent::tearDown
|
code looks good beside the stuff mentioned by @nickvergessen 👍 |
rullzer
force-pushed
the
move_public_webdav_auth_to_share_manager
branch
from
bb58642 to
03f9636
Compare
|
@nickvergessen fixed your comments |
|
Works, can still access password protected shares and also mount them as remote shares 👍 |
If we do not allow public upload we should limit the permissions on links shares upon retrieval. * Added unit test * Allow fetching federated shares by token as well
The public webdav auth should use the shiny new share manager.
rullzer
force-pushed
the
move_public_webdav_auth_to_share_manager
branch
2 times, most recently
from
058d80f to
eda7124
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #22209
This moves over the webdav public auth to the sharemanager.
As a bonus we now finally have (at least some) unit tests for the webdav public auth!
CC: @PVince81 @schiesbn @DeepDiver1975 @nickvergessen