Migrate post_groupDelete hook to share manager #23841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
force-pushed
the
share_move_delete_group_hook
branch
from
b62c7d2 to
d067fa8
Compare
rullzer
changed the title
rullzer
force-pushed
the
share_move_delete_group_hook
branch
from
d067fa8 to
3c17669
Compare
|
Apparently I do something mysql does not like... I'll look into it |
rullzer
force-pushed
the
share_move_delete_group_hook
branch
from
3c17669 to
fe747c1
Compare
|
Ok, mysql is happy now as well. |
| $cursor->closeCursor(); | ||
|
|
||
| $offset = 0; | ||
| $slice = array_slice($ids, $offset, 100); |
There was a problem hiding this comment.
yes... lets use that indeed..
rullzer
force-pushed
the
share_move_delete_group_hook
branch
from
fe747c1 to
68953ab
Compare
| } | ||
| $cursor->closeCursor(); | ||
|
|
||
| if (count($ids) > 0) { |
rullzer
force-pushed
the
share_move_delete_group_hook
branch
from
68953ab to
1ec0865
Compare
The hook now calls the share manager that will call the responsible shareProvider to do the proper cleanup. * Unit tests added Again nothing should change it is just to cleanup old code
MorrisJobke
force-pushed
the
share_move_delete_group_hook
branch
from
1ec0865 to
5899dda
Compare
|
Rebased to retrigger CI |
|
Tested and works 👍 |
| $sql = 'SELECT `id` FROM `*PREFIX*share` WHERE `share_type` = ? AND `share_with` = ?'; | ||
| $result = \OC_DB::executeAudited($sql, array(self::SHARE_TYPE_GROUP, $arguments['gid'])); | ||
| while ($item = $result->fetchRow()) { | ||
| Helper::delete($item['id']); |
There was a problem hiding this comment.
Can we delete Helper::delete() as well, or is it still used from elsewhere?
There was a problem hiding this comment.
Okay seems to be still used.
There was a problem hiding this comment.
yeah not yet... but 🔜
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #22209
The hook now calls the share manager that will call the responsible
shareProvider to do the proper cleanup.
Again nothing should change it is just to cleanup old code
CC: @schiesbn @nickvergessen @PVince81 @MorrisJobke @DeepDiver1975