Translate OCS Share API error messages

[rullzer]

For #22209

Translat the error messages returned by the OCS Share API. This way clients can get properly translated messages if they want to show what the server returned.

CC: @nickvergessen @MorrisJobke @PVince81 @schiesbn

[DeepDiver1975]

@MTRichards mind reviewing some strings again? THX

[nickvergessen]

This will mostlikely break things again :-(

[MTRichards]

Ok, so the following changes - I think in two places in this pull request.

Public upload is only possible for public shared folders

Public upload is only possible for publicly shared folders

Invalid Date, format must be YYYY-MM-DD

Invalid date, date format must be YYYY-MM-DD

Sharing %s failed, because the backend does not allow shares from type %s

Sharing %s failed because the beck end does not allow shares from type %s

Wrong share Id, share doesn't exist

Wrong share ID, share doesn't exist

Public upload is only possible for public shared folders

Public upload is only possible for publicly shared folders

Can't change permission for public link share

Can't change permissions for public share links

[rullzer]

thanks @MTRichards fixed.

[MorrisJobke]

thanks @MTRichards fixed.

Please also fix the strings in the unit tests.

[rullzer]

Ah right... to early... will take care...

[rullzer]

Unit tests adjusted!

[MorrisJobke]

Sharing still work 👍

[PVince81]

This will mostlikely break things again :-(

@nickvergessen Please elaborate / help on this topic.

[rullzer]

It is because some smash box test check for the error message. Since we have a very limited set of error codes.

[nickvergessen]

Seems like I switched to status code last time, but better be save and run the full suite once:
https://github.com/owncloud/smashbox/blob/master/python/smashbox/utilities/__init__.py#L682-L684

I will do that now

[schiessle]

Hm, in the past we agreed that public API responses shouldn't be translated, if I remember correctly. But in this case all API calls happen as a specific logged-in user, so it is probably OK.... 👍

[rullzer]

@schiesbn O wasn't aware of that.
The issue here is that the response codes from the OCS Share API are to limited. So often clients will just display the error message from the server. It is weird if that is in english while the users might have a different language on their system.

[DeepDiver1975]

@schiesbn O wasn't aware of that.
The issue here is that the response codes from the OCS Share API are to limited. So often clients will just display the error message from the server. It is weird if that is in english while the users might have a different language on their system.

Some releases back we did add the capability to read the client's language from the request and send back the messages in the asked language.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.