Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add locks in the scanner to prevent multiple scanners running on the … #24205

Merged
merged 1 commit into from
Apr 25, 2016
Merged

add locks in the scanner to prevent multiple scanners running on the … #24205

merged 1 commit into from
Apr 25, 2016

Conversation

icewind1991
Copy link
Contributor

…same files

Fixes #20555

@adamreed90 @BenS89 @pako81 @hostingnuggets can you verify if this fixes the issue for you

cc @PVince81 @MorrisJobke

@icewind1991 icewind1991 added this to the 9.1-current milestone Apr 22, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @mmattel, @ringmaster and @butonic to be potential reviewers

@PVince81
Copy link
Contributor

👍 tested here #20555 (comment) and it solved the problem for me

@PVince81 PVince81 mentioned this pull request Apr 25, 2016
Closed
@PVince81
Copy link
Contributor

Retested with the correct transaction modes, still works.

@PVince81
Copy link
Contributor

Second review ? @nickvergessen @schiesbn @rullzer @DeepDiver1975

@rullzer
Copy link
Contributor

rullzer commented Apr 25, 2016

Basically tested the same way as #20555 (comment)

👍

@PVince81
Copy link
Contributor

@karlitschek backport to 9.0.2, 8.2.4 ? (fixes database dead lock with concurrent scanner processes)

@rullzer
Copy link
Contributor

rullzer commented Apr 25, 2016

Rebased to make github happy after the move to PSR-4

@karlitschek
Copy link
Contributor

nice. please backport

@DeepDiver1975 DeepDiver1975 merged commit 5348424 into master Apr 25, 2016
@DeepDiver1975 DeepDiver1975 deleted the scanner-locking branch April 25, 2016 12:48
@MorrisJobke
Copy link
Contributor

nice. please backport

@icewind1991 Could you please open the backport PRs?

@icewind1991 icewind1991 mentioned this pull request Apr 25, 2016
Merged
@PVince81
Copy link
Contributor

@icewind1991 what happened to the 8.2 backport in the end ? (I know you pushed by mistake, did you revert?)

@icewind1991 icewind1991 mentioned this pull request Apr 25, 2016
Merged
@icewind1991
Copy link
Contributor Author

did you revert

Yes

stable9: #24250
stable8.2: #24260

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
4 - To release blue-ticket comp:filesystem
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.

"Deadlock found when trying to get lock" in file locking
7 participants
@icewind1991 @mention-bot @PVince81 @rullzer @karlitschek @MorrisJobke @DeepDiver1975